Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hillbrad/new format sri #1821

Merged
merged 3 commits into from
May 18, 2015
Merged

Hillbrad/new format sri #1821

merged 3 commits into from
May 18, 2015

Conversation

hillbrad
Copy link
Contributor

Update of Subresource Integrity tests to use new integrity format and crossorigin rules. Contains some 'stub' tests for algorithm priority that won't pass anywhere yet and will need updating in the future. No tests yet, just <script>

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4977

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

true,
"Same-origin script with correct hash.",
"matching-digest.js",
"sha256-EKclUXH9SRRUv3FmL7bIEV0z2s3EvzHFxzHKCnfHT/E="
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we never get around to updating the spec to b64_urlsafe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I see.

@devd
Copy link

devd commented May 16, 2015

accepted, btw.

hillbrad added a commit that referenced this pull request May 18, 2015
@hillbrad hillbrad merged commit 093dfbf into web-platform-tests:master May 18, 2015
@hillbrad hillbrad deleted the hillbrad/new-format-sri branch May 18, 2015 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants