-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the Frame Timing API #1894
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/5251 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
The attribute name of frame number is 'sourceFrameNumber', not 'sourceFrame'. I think the chrome implementation is wrong. |
… on a strict strict timing for render events.
I've renamed sourceFrame as sourceFrameNumber, and relaxed the render tests to not rely on strict timing for the startTime |
….js. Remove incorrect test case in test_frame_timing_offpage_iframe.html.
@plehegar @igrigorik @mpb @mithro, this is one of the oldest PRs in wpt with no activity. I found you via https://github.com/WICG/frame-timing/graphs/contributors and wonder if the Frame Timing API is still an active idea, or if this PR should just be closed? |
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
@foolip It's not, we parked FT. Closing. Thanks for catching this one. |
No description provided.