Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the Frame Timing API #1894

Closed

Conversation

ericwoodwork
Copy link

@ericwoodwork ericwoodwork commented Jun 11, 2015

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5251

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@hiikezoe
Copy link
Contributor

The attribute name of frame number is 'sourceFrameNumber', not 'sourceFrame'. I think the chrome implementation is wrong.

… on a strict strict timing for render events.
@ericwoodwork
Copy link
Author

I've renamed sourceFrame as sourceFrameNumber, and relaxed the render tests to not rely on strict timing for the startTime

….js. Remove incorrect test case in test_frame_timing_offpage_iframe.html.
@foolip
Copy link
Member

foolip commented Nov 26, 2018

@plehegar @igrigorik @mpb @mithro, this is one of the oldest PRs in wpt with no activity. I found you via https://github.com/WICG/frame-timing/graphs/contributors and wonder if the Frame Timing API is still an active idea, or if this PR should just be closed?

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@igrigorik
Copy link
Member

@foolip It's not, we parked FT. Closing. Thanks for catching this one.

@igrigorik igrigorik closed this Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants