adds test coverage for the html li@type #2380
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/6008 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Reviewers for this pull request are: @w3c/html-reviewers. |
|
comments in critic |
common-nighthawk
force-pushed
the
li-html-add-coverage
branch
from
d917b8b
to
488866c
Compare
fixes tests for li@type, allowing li's in ol, ul, and alone to support all types.
common-nighthawk
force-pushed
the
li-html-add-coverage
branch
from
fe518ce
to
40d852f
Compare
|
thanks for the detailed comments in critic. i misunderstood the documentation, and made changes to the tests accordingly. unfortunately, i made a mistake using git. i went to squash some of my commits before updating the PR, and was off by one in my count. i combined some of my new updates with the initial one. because that seemed extra-messy, i just went back and combined all of my commits (starting from the original) into one. bleh! i know this messes up critic. im sorry about that. the changes in this PR are correct, just combined. let me know if you want me to submit anything in a different way to fix this. |
|
Lgtm |
adds test coverage for the html li@type
No description provided.