New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission/microsoft/pointer events #324
Submission/microsoft/pointer events #324
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/305 This is an external review system which you may optionally use for the code review of your pull request. |
</h4> | ||
<br /> | ||
<div id="target0"> | ||
Prese and hold a mouse button,or use touch or pen to contact this element. Move around inside the element while maintaining contact/button down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos here: s/Prese/Press/ and s/,or/, or/
Some general comments.
|
Also, can we have more consistent file names please? Now we have
but
etc. |
test(function () { | ||
assert_equals(event.tiltX, 0, event.type + ".tiltX is 0 for mouse"); | ||
assert_equals(event.tiltY, 0, event.type + ".tiltY is 0 for mouse"); | ||
assert_equals(event.pointerId, 1, event.type + ".pointerId is 1 for mouse"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer in the spec and should be removed.
A few more general comments.
|
if (eventTested == false) { | ||
detected_pointertypes[event.pointerType] = true; | ||
|
||
test(function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix indentation of this block
PR324 comments processed.
@ArtemAntonets, @jacobrossi what's this PR still waiting on before we can merge it? |
All comments processed except 3 that I've commented here. And also 1 from here: https://critic.hoppipolla.co.uk/showcomment?chain=3710 Simon asks to add "_manual" to the pages that require manual interaction that will lead to renaming all the files except just 2 that are automatic. This will make review process to be very difficult. In case this change is reasonable, I would suggest to create according issue and make a separate PR with only name change. |
@ArtemAntonets - please note the file naming convention for manual tests is to use a dash ("-") and not an underscore ("_"). Thus, f.ex. "pointerleave-manual.html" |
Contains an initial set of Pointer Event test case submissions from Microsoft and also a bug fix to an existing test case. Additional submissions will follow.