app-URI spec compliance tests #325
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/306 This is an external review system which you may optionally use for the code review of your pull request. |
|
Is this something that we expect to be implemented by browsers for open web content with no specific extra security permissions? If not, it should not be in WPT. I would suggest a repo similar to WPT for system-level APIs. |
|
Well, hopefully, there exist as little system-level specific APIs as possible. I'd be in favor of centralizing the test repo as much as we can and maybe blacklisting system-level specific tests at the test runner level or through a manifest file at the root of the repo. |
|
I'm easy. This is a fairly obscure feature. |
|
We're still awaiting some action on this PR. If somebody can actually review the PR (@marcoscaceres?) then we'd be closer to being able to merge it, and we could just add the "app-uri" dir to the runner blacklist for now at least (until some separate repo exists for sysapps tests). |
sideshowbarker
added
stale-awaiting-submitter-response
and removed
stale-awaiting-submitter-response
labels
|
Ok, will try to do it in the next week. |
|
Ok, I've done the review. I found one typo in a comment, but apart from that it all looks fine to me. |
Can you please go ahead and merge it, then? Or can I go ahead and merge it, with a note that you've reviewed it? btw, Did you actually post a comment about that typo somewhere? I don't see anything about it here or at https://critic.hoppipolla.co.uk/r/306 If it's just a typo in a comment, then I think we should merge this as-is and just commit the fix for the typo on master after that. |
|
@sideshowbarker I don't have merge privileges. Agree about the typo. |
|
(the typo is in a comment, no big deal) |
app-URI spec compliance tests
|
@marcoscaceres OK, thanks |
Test suite copied from:
https://github.com/sysapps/testsuites/tree/gh-pages/app-URI
First stable version