Added assertionCache loading and tracability #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON Schema referenced in assertions by name (e.g., "foo.json") were being loaded but not placed in the cache. This meant that they were not actually being used when testing. Also improved the output when there are subtests to make it easier to evaluate which assertion was being evaluated (since assertions are evaluated bottom-up if there is complex nesting). Finally, also changed relative URI handling so that we know the complete path of each component loaded to make it easier to debug.
|
Critic review: https://critic.hoppipolla.co.uk/r/6699 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Reviewers for this pull request are: @BigBlueHat and @halindrome. |
|
@BigBlueHat r? |
|
LGTM! 👍 |
ddorwin
pushed a commit
to ddorwin/web-platform-tests
that referenced
this pull request
Sep 13, 2016
JSON Schema referenced in assertions by name (e.g., "foo.json") were being loaded but not placed in the cache. This meant that they were not actually being used when testing. Also improved the output when there are subtests to make it easier to evaluate which assertion was being evaluated (since assertions are evaluated bottom-up if there is complex nesting). Finally, also changed relative URI handling so that we know the complete path of each component loaded to make it easier to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON Schema referenced in assertions by name (e.g., "foo.json") were
being loaded but not placed in the cache. This meant that they were not
actually being used when testing.
Also improved the output when there are subtests to make it easier to
evaluate which assertion was being evaluated (since assertions are
evaluated bottom-up if there is complex nesting).
Finally, also changed relative URI handling so that we know the complete
path of each component loaded to make it easier to debug.