-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eme] Initial check-in of new EME test framework #3355
Conversation
Reviewers for this pull request are: @ddorwin. |
Critic review: https://critic.hoppipolla.co.uk/r/6751 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
<div id='log'></div> | ||
|
||
<div id='video'> | ||
<video id="videoelement" width="600px"></video> | ||
<video id="videoelement" width="200px"></video> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this size change? I guess an arbitrarily small element is fine for testing, but this seems not a typical end user size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason - just wanted them all the same size across all the tests and not too big.
I had some high level questions, but in general think this is ready to merge. I'd very much like to run the tests directly, and will need PlayReady support included to do that with Edge. |
@jdsmith3000 I think the only thing preventing this test case from working with Edge is |
…3355) * Simple temporary session playback test * Updated utilities * Remove unneeded Chimera content * Address review comment regarding waitForEventAndRunStep * Enable DRM tests on Edge with PlayReady
No description provided.