Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eme] Initial check-in of new EME test framework #3355

Merged
merged 7 commits into from
Jul 30, 2016

Conversation

mwatson2
Copy link
Contributor

No description provided.

@wpt-pr-bot
Copy link
Collaborator

Reviewers for this pull request are: @ddorwin.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6751

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

<div id='log'></div>

<div id='video'>
<video id="videoelement" width="600px"></video>
<video id="videoelement" width="200px"></video>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this size change? I guess an arbitrarily small element is fine for testing, but this seems not a typical end user size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason - just wanted them all the same size across all the tests and not too big.

@jdsmith3000
Copy link
Contributor

I had some high level questions, but in general think this is ready to merge. I'd very much like to run the tests directly, and will need PlayReady support included to do that with Edge.

@mwatson2
Copy link
Contributor Author

@jdsmith3000 I think the only thing preventing this test case from working with Edge is getSupportedKeySystem in util/utils.js.

@mwatson2 mwatson2 merged commit fe11cc9 into web-platform-tests:master Jul 30, 2016
ddorwin pushed a commit to ddorwin/web-platform-tests that referenced this pull request Sep 13, 2016
…3355)



* Simple temporary session playback test

* Updated utilities

* Remove unneeded Chimera content

* Address review comment regarding waitForEventAndRunStep

* Enable DRM tests on Edge with PlayReady
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants