Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eme] Four non-playback tests migrated from Blink tests #3362

Merged
merged 1 commit into from
Jul 30, 2016

Conversation

mwatson2
Copy link
Contributor

This PR is dependent on #3355

@wpt-pr-bot
Copy link
Collaborator

Reviewers for this pull request are: @ddorwin.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6758

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

} );
</script>
</body>
</html>
Copy link
Contributor

@jdsmith3000 jdsmith3000 Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new Clear Key test?

Update: Wait, is this a new version of encrypted-media-events.html? It's fairly different, and I hadn't recognized you were updating the Clear Key tests for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the script associated with this was based on encrypted-media-events. The idea is that the new scripts in the scripts folder can be called from multiple HTML files so that we can easily get { clear key, drm } x { mp4, webm } where the Google tests were just clear key + webm.

@jdsmith3000
Copy link
Contributor

The general structure of these tests seems pretty flexible. LGTM for merge.

@mwatson2 mwatson2 merged commit 3080c9f into web-platform-tests:master Jul 30, 2016
ddorwin pushed a commit to ddorwin/web-platform-tests that referenced this pull request Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants