New presentation start tests that trigger a mixed content error #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests need to run over HTTPS, hence the ".https.html" extension. They create a PresentationRequest with an HTTP URL and ensure that "start" reports a SecurityError exception.
|
Reviewers for this pull request are: @louaybassbouss, @tidoust, and @zqzhang. |
The tests are semi-manual and the test harness gets confused if the button gets clicked more than once. Disabling the button ensures the user will only run the test once. Also, since the page only contains one test, it is good practice to use the title of the page to convey the name of the test.
The tests check "reconnect" and "getAvailability" mixed content steps.
|
I extended the scope of this pull request to cover other parts of the Presentation API that also require user agents to check for mixed content and throw a |
|
Thx @tidoust LGTM |
tidoust
deleted the
presentation-api-startNewPresentation-mixedcontent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests need to run over HTTPS, hence the
.https.htmlextension. They create aPresentationRequestwith an HTTP URL and ensure thatstartreports aSecurityErrorexception.Note the tests will pass if they are run over HTTP by mistake (since there would not be any "mixed content" anymore), which could be confusing. A short exchange on IRC suggested that individual test files should not check the protocol themselves, but that the test harness could perhaps be updated to report the error. I prepared a PR on testharness.js accordingly: w3c/testharness.js#207