AmbientLightSensor: add some basic functionality tests #3696
Conversation
|
Reviewers for this pull request are: @Volker-E, @dontcallmedom, @riju, @tobie, and @zqzhang. |
| }); | ||
|
|
||
| test(function() { | ||
| assert_equals(sensor.state, "activating"); |
There was a problem hiding this comment.
I think it is better to put all these assertions in this test file together within ambient-light/AmbientLightSensor_onstatechange.html.
There was a problem hiding this comment.
@zqzhang, thanks for your comments! Agree!
|
@Honry I mean it is better to combine all the tests in |
|
@zqzhang, initially I designed 3 test files for onstatechange, start, and stop since they may be extended with more checkpoints in future, such as permission, 'active' state, reporting mode and etc., to make each test file distinct. WDYT? |
Cover start(), stop(), onchange, onstatechange and secure stuff when browsing context
Which has been covered in AmbientLightSensor_onstatechange.html
Cover start(), stop(), onchange, onstatechange and also secure stuff when browsing context