Upstream a test for CustomElementRegistry interface from WebKit #3782
Conversation
|
Reviewers for this pull request are: @alsemenov, @deepak-sa, @domenic, @dominiccooney, @hayatoito, @kojiishi, @rniwa, @sgrekhov, and @TakayoshiKochi. |
|
|
||
| test(function () { | ||
| customElements.define('custom-html-element', HTMLElement); | ||
| }, 'customElements.define must not throw the constructor is HTMLElement'); |
There was a problem hiding this comment.
Grammar: throw the constructor -> throw if the constructor
| calls.push(name); | ||
| return target[name]; | ||
| } | ||
| }) |
There was a problem hiding this comment.
Maybe trailing semi here to not rely on automatic insertion?
|
|
||
| (function () { | ||
| var testCase = async_test('customElements.define must not throw' | ||
| +' when defining another custom element in a different global object during Get(constructor, "prototype")', {timeout: 100}); |
There was a problem hiding this comment.
Style: maybe space between + and '
|
It's worth noting we have some tests already in https://github.com/w3c/web-platform-tests/blob/master/custom-elements/custom-element-registry/define.html. I'm fine with duplicate coverage (more tests better!), but we might want to consider the folder structure a bit more closely. E.g. maybe this should be split up into define-2.html, whenDefined.html, etc.? It's more important to land though so don't let that stop you. |
|
We have evolved defined.html downstream so it might be easier to upstream them as-is and do the merging upstream. |
OK, will merge this to master as-is then |
No description provided.