Use () => element.requestFullscreen() to make errors more obvious #4506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the unprefixed API isn't supported, it would currently fail with "TypeError: Unable to get property 'bind' of undefined or null reference" or similar, obscuring the root cause.
|
Notifying @aliams, @foolip, @jernoble, and @upsuper. (Learn how reviewing works.) |
ChromeTesting revision d82744d |
FirefoxTesting revision d82744d |
|
Prompted by mail from @aliams. Now running the tests manually will actually time out instead, because the code that throws isn't wrapped in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the unprefixed API isn't supported, it would currently fail with
"TypeError: Unable to get property 'bind' of undefined or null
reference" or similar, obscuring the root cause.