Fullscreen: give trusted_click and trusted_click the test for step_func #4507
Conversation
The element.requestFullscreen() is wrapped in an arrow function, which together with the other changes should make failures more obvious.
|
Notifying @aliams, @foolip, @jernoble, and @upsuper. (Learn how reviewing works.) |
|
This seems to have worked better, can you review, @aliams? |
FirefoxTesting revision dea4673 |
ChromeTesting revision dea4673 |
|
LGTM. The error messages are much clearer now. As an aside, I was wondering if there are any best practices when it comes to using the new JS operators considering that you may want to run these tests on older browsers. |
|
I don't think there's an established easy-to-follow rule for what new features are OK and not. At the very least things that don't work in the stable versions of all major browsers shouldn't be used, and for older versions I'd say it depends on the value of actually running the tests. In this case, there aren't any older browsers where these tests will work. |
See web-platform-tests/wpt#4507 This is to make it easier to fork and unfork the tests as needed while moving towards alignment between spec and implementation. For fast/media/mq-display-mode-fullscreen.html, use runWithKeyDown instead, which doesn't assume testharness.js. BUG=402376 Change-Id: I64e44356e2efa537384987aca509cff58170c04d Reviewed-on: https://chromium-review.googlesource.com/519403 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#475904}
The element.requestFullscreen() is wrapped in an arrow function, which
together with the other changes should make failures more obvious.