Update WritableStream tests #4587
Conversation
|
Notifying @calvaris, @domenic, @tyoshino, @wanderview, @youennf, and @yutakahirano. (Learn how reviewing works.) |
|
The spec side change is also still under review. |
tyoshino
force-pushed
the
updatewritablestream
branch
from
a81b8b3
to
6a08c8c
Compare
|
Rebased. The last commit before rebase was: a81b8b3 |
tyoshino
force-pushed
the
updatewritablestream
branch
from
6a08c8c
to
f5c2f75
Compare
|
Rebased again onto fb0caa1 to sync with the point specified for the submodule in the streams repo. |
| @@ -164,6 +164,30 @@ promise_test(t => { | |||
| .then(() => promise_rejects(t, new TypeError(), writer.close(), 'close() should be rejected')); | |||
| }, 'when sink\'s write throws an error, the stream should become errored and the promise should reject'); | |||
|
|
|||
| promise_test(t => { | |||
| const passedError = new Error('horrible things'); | |||
There was a problem hiding this comment.
Since both of these have error.name === 'Error' the promise_rejects tests here are no good. Let's stick to the error1 + error2 pattern.
There was a problem hiding this comment.
Thanks. Removed passedError and thrownError from all the tests in this file and switched to use error1/error2 in a48c302
tyoshino
force-pushed
the
updatewritablestream
branch
from
f5c2f75
to
83a54c4
Compare
|
Rebased and squashed. The last commit before that was f5c2f75. |
- Fixes the test description of one test - Modified some tests to check promise fulfillment/rejection order - Added tests to check the order and timing of promise fulfillment/rejection when writer.abort() is called while there's a pending writer.write() or writer.close() - Added tests to check that writer.releaseLock() doesn't hit assertions when called while there's a pending writer.write() or writer.close() - Added tests to check an error from which of controller.error(), sink.write()/close() or writer.abort()) is used for rejecting writer.write()/close() Corresponding spec side change: whatwg/streams#655
tyoshino
force-pushed
the
updatewritablestream
branch
from
a48c302
to
2885733
Compare
|
Squashed and updated the commit message. The last commit before this was a48c302. |
|
Hi Domenic, it looks I need write access to commit. Can I get it or could you please merge this? |
|
@sideshowbarker can you help give @tyoshino write access for the future? And @ricea while we're at it. |
Spec change: whatwg/streams#655