Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify and Add tests to OffscreenCanvas promise-based commit() #4604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xlai-o
Copy link
Contributor

@xlai-o xlai-o commented Jan 23, 2017

@junov: Please review. Thanks!

This pull request mainly modifies the OffscreenCanvas.commit() tests to handle the latest change in specification about a promise-based commit() in OffscreenCanvas. The changes include:

  1. Modify the two existing tests in offscreencanvas.commit.html and offscreencanvas.commit.w.html to promise_tests. In particular, we test the assert pixels after the promise returned by commit() is resolved.
  2. Add one more test that assert the pixels in OffscreenCanvas to be non-zero after commit(). This is an adaptation of an existing layout test in Chromium.

@wpt-pr-bot
Copy link
Collaborator

Notifying @deniak, @dontcallmedom, and @zqzhang. (Learn how reviewing works.)

@xlai-o xlai-o changed the title Modified and added tests to OffscreenCanvas promise-based commit() Modify and Add tests to OffscreenCanvas promise-based commit() Jan 23, 2017
@junov
Copy link
Contributor

junov commented Jan 23, 2017

Theses tests are great, but let's wait for the promise-returning-commit to be added to the whatwg spec before landing this. There's a conf call tomorrow with participants of the WebGL working group where we'll discuss this. Once multi-vendor support is established, we'll move forward with the spec change, then we can land these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants