Add a missing PerformanceTiming readonly attribute name #4714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any PerformanceTiming interface readonly attribute name should cause a SyntaxError when used by performance.mark in Window. Although this attribute is specially optional, it is a readonly attribute in the interface, so it should be tested.
Spec for
performance.mark
:Spec for
PerformanceTiming
:Spec for
secureConnectionStart
:Firefox does not appear to support
secureConnectionStart
yet. So adding this attributes causes Firefox to fail a few tests.An alternative solution would be to only add "secureConnectionStart" to this list if it is supported by the browser, but I'm not sure that matters given the spec text above. Any read only attribute should throw a SyntaxError. I don't think supported or not matters.