New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt sensor idlharness tests to latest spec #4793
Conversation
Notifying @Volker-E, @dontcallmedom, @riju, @tobie, and @zqzhang. (Learn how reviewing works.) These tests will be available on w3c-test.org shortly after they are approved by a repository collaborator. |
Chrome (unstable channel)Testing web-platform-tests at revision 10c79cb |
Firefox (nightly channel)Testing web-platform-tests at revision 10c79cb All results5 tests ran/accelerometer/idlharness.https.html
/ambient-light/idlharness.https.html
/gyroscope/idlharness.https.html
/magnetometer/idlharness.https.html
/orientation-sensor/idlharness.https.html
|
These tests are now available on w3c-test.org |
577d5bb
to
fb3e1e7
Compare
LintPassed |
@tobie, could you help review this PR? All the Web IDL tests for Sensors are update-to-date. |
|
||
<script> | ||
|
||
(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there guidelines wrt what flavor of ES should be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so I checked on irc ans the answer is: "Has to work in latest Chrome, Fx, Safari, Edge".
So you're good.
- Add Web IDL test for Orientation Sensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So seems mostly like a copy/paste job from the spec, so LGTM. :)
Thanks @tobie! I am going to merge it. |
This change is