Adding filter and resize tests #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox (nightly channel)Testing web-platform-tests at revision 6f0fda6 |
|
The tests look good to me but you need to fix the lint errors and the flake. Aren't you missing a "-ref" for worker test? |
|
These tests are now available on w3c-test.org |
|
@junov I've converted the flaky filter tests to non-reference tests. Could you take a look at them to see if they can be merged? |
|
These are excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@junov
These 3 tests are the remaining offscreencanvas tests (unrelated to commit()) that are in Chromium Layout tests but not in web-platform-tests. The two newly added tests for offscreencanvas.filter are reference tests.