Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streams/: Fix issues found by eslint #5069

Merged
merged 1 commit into from Mar 8, 2017

Conversation

ricea
Copy link
Contributor

@ricea ricea commented Mar 8, 2017

There is no requirement for tests to pass eslint, but I find it a useful tool
for debugging so I cleaned up a few non-controversial issues in the streams/
test directory.

Fixed:

  • Unused variables
  • Missing '()' invoking a constructor
  • 'cancelPromise' is never reassigned. Use 'const' instead
  • Missing semicolon
  • '+' should be placed at the end of the line (subjective, but probably nobody
    cares enough to object)
  • This line has 2 statements. Maximum allowed is 1
  • Use the rest parameters instead of 'arguments'

Not changed:

  • Variable 'ignoredReadPromise' is unused on purpose
  • Lines > 120 (no universal agreement on this)
  • Arrow function should not return assignment (no universal agreement)
  • A space is required after '{' / before '}' (no universal agreement)

There is no requirement for tests to pass eslint, but I find it a useful tool
for debugging so I cleaned up a few non-controversial issues in the streams/
test directory.

Fixed:

- Unused variables
- Missing '()' invoking a constructor
- 'cancelPromise' is never reassigned. Use 'const' instead
- Missing semicolon
- '+' should be placed at the end of the line (subjective, but probably nobody
  cares enough to object)
- This line has 2 statements. Maximum allowed is 1
- Use the rest parameters instead of 'arguments'

Not changed:

- Variable 'ignoredReadPromise' is unused on purpose
- Lines > 120 (no universal agreement on this)
- Arrow function should not return assignment (no universal agreement)
- A space is required after '{' / before '}' (no universal agreement)
@wpt-pr-bot
Copy link
Collaborator

@domenic domenic merged commit e02c66a into web-platform-tests:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants