Add the background-fetch directory with an IDL Harness test #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox (nightly channel)Testing web-platform-tests at revision 22ed4d4 All results2 tests ran/background-fetch/interfaces-worker.https.html
/background-fetch/interfaces.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 22ed4d4 All results2 tests ran/background-fetch/interfaces-worker.https.html
/background-fetch/interfaces.html
|
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Mar 11, 2017
This CL introduces the BackgroundFetchManager object and exposes it on the ServiceWorkerRegistration, as part of a new Background Fetch module. More functionality and tests will be added iteratively. Intent to Implement: https://groups.google.com/a/chromium.org/d/topic/blink-dev/Ia9_-CVrl1U/discussion WPT directory addition + IDL harness tests: web-platform-tests/wpt#5094 Based on the following CL by awdf@: https://codereview.chromium.org/2739653002/ BUG=692534 Review-Url: https://codereview.chromium.org/2736143003 Cr-Commit-Position: refs/heads/master@{#456102}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Mar 11, 2017
This CL implements the get() and fetch() methods for Background Fetch. The BackgroundFetchRegistration interface and BackgroundFetchOptions and IconDefinition dictionary types are added too. The method has not been hooked up with the browser process yet, as the Mojo interface has not been implemented yet. Tests are provided, and will be moved to the WPT directory once it has been approved upstream: web-platform-tests/wpt#5094 BUG=692534 Review-Url: https://codereview.chromium.org/2745543002 Cr-Commit-Position: refs/heads/master@{#456144}
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the Background Fetch API that @jakearchibald has proposed in the WICG:
http://wicg.github.io/background-fetch/
The tests are ran both in a document and in a Service Worker.