New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetch-event-redirect.https.html layout test using promise_test #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is crashing on Debug build because of OOM. This CL changes the test to use promise_test instead of async_test inorder not to start multiple service workers in parallel. BUG=698872 Review-Url: https://codereview.chromium.org/2738143002 Cr-Commit-Position: refs/heads/master@{#455680}
Notifying @ehsan and @mkruisselbrink. (Learn how reviewing works.) |
Firefox (nightly channel)Testing web-platform-tests at revision b398e39 All results1 test ran/service-workers/service-worker/fetch-event-redirect.https.html
|
Chrome (unstable channel)Testing web-platform-tests at revision b398e39 All results1 test ran/service-workers/service-worker/fetch-event-redirect.https.html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is crashing on Debug build because of OOM.
This CL changes the test to use promise_test instead of async_test inorder not to start multiple service workers in parallel.
BUG=698872
Review-Url: https://codereview.chromium.org/2738143002
Cr-Commit-Position: refs/heads/master@{#455680}