IndexedDB: Add tests for event properties #5108
Conversation
|
Notifying @chunywang, @dumbmatter, @odinho, @yunxiaoxie, @zhaozihao, and @zqzhang. (Learn how reviewing works.) |
|
@pwnall - can you review these? w3c/IndexedDB#86 for context Note that the test and spec disagree about the cancelable attribute for the event fired from |
Firefox (nightly channel)Testing web-platform-tests at revision 5f8cbf4e1d5743d9fad01ac167ab48ddcd134fea All results2 tests ran/IndexedDB/idbfactory-open-error-properties.html
/IndexedDB/transaction-abort-request-error.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 5f8cbf4e1d5743d9fad01ac167ab48ddcd134fea All results2 tests ran/IndexedDB/idbfactory-open-error-properties.html
/IndexedDB/transaction-abort-request-error.html
|
| assert_equals(request.error.name, 'AbortError', | ||
| 'Request\'s error should be AbortError'); | ||
|
|
||
| assert_equals(e.target, request, 'event target was request'); |
There was a problem hiding this comment.
Why is this "was" rather than the usual "should be"?
There was a problem hiding this comment.
No reason. Probably just sleepy - I'll fix.
) The spec defines the error events thrown from open() and deleteDatabase() with cancelable false, but implementations have this as true. Align the spec with reality. Also: * Make various asides into details with summaries - for "why aren't the normal fire a success/error event steps used?", and to explain why the name and version getters are convoluted. * Fix the autolinking for deleteIndex * Flesh out the change history with recent big changes. Tests coming in: web-platform-tests/wpt#5108
Add tests that verify the bubbles and cancelable properties of events fired during open and transaction abort.