New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add idlharness.js tests for WebUSB. #5164
Conversation
This patch creates idlharness.js-based tests for WebUSB using a copy of the IDL index from the most recent Editor's Draft of the specification. IDL definitions related to Permissions API support are not included because they are currently unstable.
Firefox (nightly channel)Testing web-platform-tests at revision 766af1a All results1 test ran/webusb/idlharness.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 766af1a All results1 test ran/webusb/idlharness.html
|
@miguelao can you review these tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with two questions/suggestions
idl_array.add_untested_idls(document.querySelector('#untested').textContent); | ||
idl_array.add_idls(document.querySelector('#tested').textContent); | ||
idl_array.add_objects({ | ||
Navigator: ['navigator'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this object, since navigator
is untested and l.205 uses the context navigator, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Navigator interface is untested but the partial Navigator interface is tested to ensure that the usb
attribute is implemented correctly.
webusb/idlharness.html
Outdated
interface EventHandler {}; | ||
interface EventTarget {}; | ||
interface Navigator {}; | ||
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need EventInit
as well? (l.36).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idlharness.js
currently doesn't test dictionary definitions but you're right it's good to add.
These tests are now available on w3c-test.org |
*This report has been truncated because the total content is 590571 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters). Firefox (nightly channel)Testing web-platform-tests at revision 707162e All results64 tests ran/2dcontext/pixel-manipulation/2d.imageData.create2.double.html
/2dcontext/pixel-manipulation/2d.imageData.create2.zero.html
/2dcontext/pixel-manipulation/2d.imageData.get.double.html
/2dcontext/pixel-manipulation/2d.imageData.get.zero.html
/IndexedDB/idbobjectstore_createIndex15-autoincrement.htm
/content-security-policy/connect-src/connect-src-beacon-blocked.sub.html
/content-security-policy/connect-src/connect-src-eventsource-blocked.sub.html
/content-security-policy/connect-src/connect-src-websocket-blocked.sub.html
/content-security-policy/connect-src/connect-src-xmlhttprequest-blocked.sub.html
/content-security-policy/inside-worker/dedicated-inheritance.html
/content-security-policy/inside-worker/dedicated-script.html
/content-security-policy/inside-worker/shared-inheritance.html
/content-security-policy/inside-worker/shared-script.html
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image-from-script.sub.html
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image.sub.html
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-image-from-script.sub.html
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-image.sub.html
/content-security-policy/worker-src/dedicated-child.sub.html
/content-security-policy/worker-src/dedicated-fallback.sub.html
/content-security-policy/worker-src/dedicated-list.sub.html
/content-security-policy/worker-src/dedicated-none.sub.html
/content-security-policy/worker-src/dedicated-self.sub.html
/content-security-policy/worker-src/service-child.https.sub.html
/content-security-policy/worker-src/service-fallback.https.sub.html
/content-security-policy/worker-src/service-list.https.sub.html
/content-security-policy/worker-src/service-none.https.sub.html
/content-security-policy/worker-src/service-self.https.sub.html
/content-security-policy/worker-src/shared-child.sub.html
/content-security-policy/worker-src/shared-fallback.sub.html
/content-security-policy/worker-src/shared-list.sub.html
/content-security-policy/worker-src/shared-none.sub.html
/content-security-policy/worker-src/shared-self.sub.html
/cors/preflight-failure.htm
/dom/events/EventTarget-dispatchEvent.html
/dom/nodes/Document-createEvent.html
|
*This report has been truncated because the total content is 695536 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters). Chrome (unstable channel)Testing web-platform-tests at revision 707162e All results64 tests ran/2dcontext/pixel-manipulation/2d.imageData.create2.double.html
/2dcontext/pixel-manipulation/2d.imageData.create2.zero.html
/2dcontext/pixel-manipulation/2d.imageData.get.double.html
/2dcontext/pixel-manipulation/2d.imageData.get.zero.html
/IndexedDB/idbobjectstore_createIndex15-autoincrement.htm
/content-security-policy/connect-src/connect-src-beacon-blocked.sub.html
/content-security-policy/connect-src/connect-src-eventsource-blocked.sub.html
/content-security-policy/connect-src/connect-src-websocket-blocked.sub.html
/content-security-policy/connect-src/connect-src-xmlhttprequest-blocked.sub.html
/content-security-policy/inside-worker/dedicated-inheritance.html
/content-security-policy/inside-worker/dedicated-script.html
/content-security-policy/inside-worker/shared-inheritance.html
/content-security-policy/inside-worker/shared-script.html
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image-from-script.sub.html
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image.sub.html
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-image-from-script.sub.html
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-image.sub.html
/content-security-policy/worker-src/dedicated-child.sub.html
/content-security-policy/worker-src/dedicated-fallback.sub.html
/content-security-policy/worker-src/dedicated-list.sub.html
/content-security-policy/worker-src/dedicated-none.sub.html
/content-security-policy/worker-src/dedicated-self.sub.html
/content-security-policy/worker-src/service-child.https.sub.html
/content-security-policy/worker-src/service-fallback.https.sub.html
/content-security-policy/worker-src/service-list.https.sub.html
/content-security-policy/worker-src/service-none.https.sub.html
/content-security-policy/worker-src/service-self.https.sub.html
/content-security-policy/worker-src/shared-child.sub.html
/content-security-policy/worker-src/shared-fallback.sub.html
/content-security-policy/worker-src/shared-list.sub.html
/content-security-policy/worker-src/shared-none.sub.html
/content-security-policy/worker-src/shared-self.sub.html
/cors/preflight-failure.htm
/dom/events/EventTarget-dispatchEvent.html
/dom/nodes/Document-createEvent.html
|
This patch creates idlharness.js-based tests for WebUSB using a copy of the IDL index from the most recent Editor's Draft of the specification. IDL definitions related to Permissions API support are not included
because they are currently unstable.