Add tests for bluetooth interface #5219
Conversation
Test bluetooth against spec https://webbluetoothcg.github.io/web-bluetooth/#bluetooth
|
To start off on the right foot, maybe we should include an |
|
Me myself shouldn't be the owner of Bluetooth (as I work on interopability not Bluetooth), do you know who I should put as owners? |
Firefox (nightly channel)Testing web-platform-tests at revision 52cbcbc |
Chrome (unstable channel)Testing web-platform-tests at revision 52cbcbc |
|
I do not. You might start by asking the specification editors if they'd like to help out. To be clear: I'm not sure if this is strictly necessary. That said, it seems wise to designate an authority on this topic who can provide reviews before we commit to maintaining tests. On a more technical note, it appears that the new file has trailing whitespace. This is causing the tests to fail. |
Remove trailing white space
|
These tests are now available on w3c-test.org |
|
Thanks jugglinmike. I agree with you that we should add an OWNERS file, I will look into who to add. |
bluetooth/interface.html
Outdated
| <script> | ||
| test(function() { | ||
| assert_true('requestDevice' in navigator.bluetooth); | ||
| assert_equals(navigator.bluetooth.prototype.requestDevice.length, 0); |
There was a problem hiding this comment.
Either navigator.bluetooth.requestDevice.length or Bluetooth.prototype.requestDevice.length.
|
Made changes based on review comments. PTAL |
There was a problem hiding this comment.
@g-ortuno, I assume this is compatible with our plans to upstream the layout tests from https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/bluetooth/?
bluetooth/OWNERS
Outdated
| @@ -0,0 +1,3 @@ | |||
| @jyasskin, | |||
There was a problem hiding this comment.
There should be no commas in these files
|
Would it make sense to modify idl-Bluetooth.html or idl-NavigatorBluetooth.html to include the length check and then upstream that test? |
|
I was thinking about adding it to idl-Bluetooth.html.
I am not sure how upstreaming works, but yeah I think that doing it that
way makes most sense.
…On Tue, Mar 28, 2017 at 6:22 PM, Giovanni Ortuno ***@***.***> wrote:
Would it make sense to modify idl-Bluetooth.html
<https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/bluetooth/idl/idl-Bluetooth.html>
or idl-NavigatorBluetooth.html
<https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/bluetooth/idl/idl-NavigatorBluetooth.html>
to include the length check and then upstream that test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5219 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC-X4I2PAwmcUUfXjICmyamvTQFPXP7Mks5rqYg-gaJpZM4MoXJc>
.
|
Tests written in: web-platform-tests/wpt#5219 BUG=701562 Review-Url: https://codereview.chromium.org/2747813006 Cr-Commit-Position: refs/heads/master@{#460147}
|
Upstreaming the idl-Bluetooth.html at: https://codereview.chromium.org/2787103002/ |
Test bluetooth against spec https://webbluetoothcg.github.io/web-bluetooth/#bluetooth