Add test for the button element #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2014 09:57
Signed-off-by: xiaojunwu <xiaojunx.a.wu@intel.com>
Signed-off-by: xiaojunwu <xiaojunx.a.wu@intel.com>
|
Critic review: https://critic.hoppipolla.co.uk/r/619 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
w3c-test:mirror |
|
Please skip the html/semantics/forms/resetting-a-form/reset-form.html in this pull request. It has been submitted in another PR. Thanks |
|
Please update the PR to remove html/semantics/forms/resetting-a-form/reset-form.html (already merged in #550) |
added 6 commits
January 28, 2014 19:49
1. The assertion of cancelable attribute. 2. The assertion of assertion descriptions. 3. The event handle pattern and etc. Signed-off-by: xiaojunwu <xiaojunx.a.wu@intel.com>
1. Remove the trailing ws 2. Move evt.preventDefault() into the test 3. Add a test to check the button type, and put the click() method into it. 4. Remove the reset-form.html, etc Signed-off-by: xiaojunwu <xiaojunx.a.wu@intel.com>
|
commits squashed and merged: 4a8dd99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.