Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that assert_equals relies on === #5751

Merged
merged 1 commit into from May 2, 2017
Merged

Conversation

tobie
Copy link
Contributor

@tobie tobie commented May 2, 2017

Sorry for creating a branch here for this. The new GH Web interface no longer lets you create branches in your own fork. :(


This change is Reviewable

Sorry for creating a branch here for this. The new GH Web interface no longer lets you create branches in your own fork. :(
@annevk
Copy link
Member

annevk commented May 2, 2017

Does it? I thought it still used ==...

@wpt-pr-bot wpt-pr-bot added the docs label May 2, 2017
@wpt-pr-bot
Copy link
Collaborator

@tobie
Copy link
Contributor Author

tobie commented May 2, 2017

@w3c-bots
Copy link

w3c-bots commented May 2, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 736688f
Using browser at version BuildID 20170501100238; SourceStamp 076a7a66096f9e8d102548397254be32eb26bc3d
Starting 10 test iterations
No tests run.

@w3c-bots
Copy link

w3c-bots commented May 2, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 736688f
Using browser at version 60.0.3080.5 dev
Starting 10 test iterations
No tests run.

@annevk
Copy link
Member

annevk commented May 2, 2017

Oh, cool. Did that change or did I just misremember?

@tobie
Copy link
Contributor Author

tobie commented May 2, 2017

I have no idea. I end-up checking every time, which is why I'm documenting it. The name's a bit of a misnomer, as other JS test frameworks tend to associate equal to == and identical to ===.

@zcorpan
Copy link
Member

zcorpan commented May 2, 2017

testharness.js has always used === here.

@tobie tobie merged commit 4bebfa7 into master May 2, 2017
@tobie tobie deleted the tobie/testharness-api-doc branch May 2, 2017 09:18
@gsnedders
Copy link
Member

It should be equivalent to Object.is, which just exposes the internal ES SameValue function.

@tobie
Copy link
Contributor Author

tobie commented May 2, 2017

@gsnedders maybe that's what should be in the doc?

@gsnedders
Copy link
Member

@tobie IMO yes, especially now there's many sensible things we can link to (like the MDN Object.is page), compared with previously where we only could have linked to the formal SameValue definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants