New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that assert_equals relies on === #5751
Conversation
Sorry for creating a branch here for this. The new GH Web interface no longer lets you create branches in your own fork. :(
Does it? I thought it still used ==... |
Notifying @dontcallmedom, @gsnedders, @sideshowbarker, and @zcorpan. (Learn how reviewing works.) |
Firefox (nightly channel)Testing web-platform-tests at revision 736688f |
Chrome (unstable channel)Testing web-platform-tests at revision 736688f |
Oh, cool. Did that change or did I just misremember? |
I have no idea. I end-up checking every time, which is why I'm documenting it. The name's a bit of a misnomer, as other JS test frameworks tend to associate equal to |
testharness.js has always used |
It should be equivalent to |
@gsnedders maybe that's what should be in the doc? |
@tobie IMO yes, especially now there's many sensible things we can link to (like the MDN |
Sorry for creating a branch here for this. The new GH Web interface no longer lets you create branches in your own fork. :(
This change is