Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[presentation-api] Add a fundamental test for defaultRequest #5767

Merged
merged 1 commit into from May 3, 2017

Conversation

tomoyukilabs
Copy link
Member

@tomoyukilabs tomoyukilabs commented May 3, 2017

This PR adds a test to confirm that navigator.presentation.defaulRequest can be set to null or any instance of PresentationRequest.


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

Notifying @louaybassbouss, @tidoust, and @zqzhang. (Learn how reviewing works.)

@w3c-bots
Copy link

w3c-bots commented May 3, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 01c2403
Using browser at version BuildID 20170502100421; SourceStamp 48c0fd9c9ec5d68061ea7b59358874ae8da72572
Starting 10 test iterations
All results were stable

All results

1 test ran
/presentation-api/controlling-ua/defaultRequest.https.html
Subtest Results Messages
OK
Setting a default presentation request FAIL navigator.presentation is undefined

@w3c-bots
Copy link

w3c-bots commented May 3, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 01c2403
Using browser at version 60.0.3080.5 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/presentation-api/controlling-ua/defaultRequest.https.html
Subtest Results Messages
OK
Setting a default presentation request PASS

Copy link
Contributor

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tidoust tidoust merged commit c739e1d into web-platform-tests:master May 3, 2017
@tomoyukilabs tomoyukilabs deleted the default-request branch May 8, 2017 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants