Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

third bunch of custom elements tests #578

Conversation

alsemenov
Copy link
Contributor

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/670

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

var doc2 = doc.implementation.createHTMLDocument('Document 2');
assert_throws('NotSupportedError', function () {
doc2.registerElement(name);
}, 'Registering a custom element type name that is already registered in a shared ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation doesn't make sense to me, because you've got zero indent at this point, but you indent four characters on the next line. You're mixing indenting aesthetically (make the function look good) and indenting continuations (logical but ugly.)

Maybe you should use more lines, eg:

assert_throws(
    'NotSupportedError',
    function() { doc2.registerElement(name); },
    'Registering a custom element ... ' +
        'registry ...');

@dglazkov
Copy link
Contributor

LGTM

dominiccooney added a commit that referenced this pull request Mar 24, 2014
…ts-3

Merge Custom Element registry sharing tests.
@dominiccooney dominiccooney merged commit d3e58c0 into web-platform-tests:master Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants