Generic Sensor: Add functionality tests for OrientationSensor #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honry
changed the title
Firefox (nightly)Testing web-platform-tests at revision 1914a86 All results10 tests ran/accelerometer/Accelerometer.https.html
/accelerometer/Accelerometer_insecure_context.html
/ambient-light/AmbientLightSensor.https.html
/ambient-light/AmbientLightSensor_insecure_context.html
/gyroscope/Gyroscope.https.html
/gyroscope/Gyroscope_insecure_context.html
/magnetometer/Magnetometer.https.html
/magnetometer/Magnetometer_insecure_context.html
/orientation-sensor/OrientationSensor.https.html
/orientation-sensor/OrientationSensor_insecure_context.html
|
Sauce (safari)Testing web-platform-tests at revision 1914a86 All results10 tests ran/accelerometer/Accelerometer.https.html
/accelerometer/Accelerometer_insecure_context.html
/ambient-light/AmbientLightSensor.https.html
/ambient-light/AmbientLightSensor_insecure_context.html
/gyroscope/Gyroscope.https.html
/gyroscope/Gyroscope_insecure_context.html
/magnetometer/Magnetometer.https.html
/magnetometer/Magnetometer_insecure_context.html
/orientation-sensor/OrientationSensor.https.html
/orientation-sensor/OrientationSensor_insecure_context.html
|
Chrome (unstable)Testing web-platform-tests at revision 1914a86 |
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 1914a86 All results10 tests ran/accelerometer/Accelerometer.https.html
/accelerometer/Accelerometer_insecure_context.html
/ambient-light/AmbientLightSensor.https.html
/ambient-light/AmbientLightSensor_insecure_context.html
/gyroscope/Gyroscope.https.html
/gyroscope/Gyroscope_insecure_context.html
/magnetometer/Magnetometer.https.html
/magnetometer/Magnetometer_insecure_context.html
/orientation-sensor/OrientationSensor.https.html
/orientation-sensor/OrientationSensor_insecure_context.html
|
Honry
force-pushed
the
sensor/absoulteorientation
branch
from
8bd4a77
to
95d5795
Compare
|
@alexshalamov, @pozdnyakov, PTAL. |
|
|
||
| let mat_64 = new Float64Array(16); | ||
| sensor.populateMatrix(mat_64); | ||
| assert_array_approx_equals(mat_64, mat_expect, double_precision); |
There was a problem hiding this comment.
why not to use assert_array_equals from testharness? DomMatrix and Float64Array would not lose precision.
There was a problem hiding this comment.
We found the test result is sometime failed due to lose precision issue in Float64Array and thought it was same as Float32Array. I will fix it and file bug if the failure occurs again.
| // Works for all supported types. | ||
| let mat_32 = new Float32Array(16); | ||
| sensor.populateMatrix(mat_32); | ||
| assert_array_approx_equals(mat_32, mat_expect, float_precision); |
There was a problem hiding this comment.
Looks like WebAudio has similar helper, maybe it needs to be moved to generic testharness?
There was a problem hiding this comment.
Indeed, I will try to add it to testharness and back to update the test once it is accepted.
There was a problem hiding this comment.
@alexshalamov, this assertion has been accepted in testharness.js, see #6682
- Do not use approx for DOMMatrix and Float64Array - Convert DOMMatrix to Float64Array for comparision
Honry
added a commit
to Honry/web-platform-tests
that referenced
this pull request
Aug 4, 2017
as it has been a generic assertion in testharness.js, see web-platform-tests#5870
gsnedders
pushed a commit
that referenced
this pull request
Aug 4, 2017
as it has been a generic assertion in testharness.js, see #5870
alexshalamov
approved these changes
Aug 4, 2017
|
@alexshalamov, thanks for your review, I will merge it directly. |
rachelandrew
pushed a commit
to rachelandrew/web-platform-tests
that referenced
this pull request
Nov 8, 2017
…atform-tests#5870) * Generic Sensor: Add functionality tests for OrientationSensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.