Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed athost tests #596

Closed

Conversation

KenjiBaheux
Copy link
Contributor

No description provided.

KenjiBaheux and others added 5 commits February 3, 2014 18:13
@host has been superseded by :host
These tests aren't relevant anymore, we will need new ones for :host
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/710

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@KenjiBaheux
Copy link
Contributor Author

@hayatoito Please, review this batch (common rationale). Thanks.

@hayatoito
Copy link
Member

test-008.html looks unrelated. Could you exclude that?
In addition that, the commits history looks a bit dirty.
Could you rebase your commits so that it looks clean?

@KenjiBaheux
Copy link
Contributor Author

Sorry, looks like I made a couple of commits with a master in poor shape: I will close them and retry from a clean base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants