Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-tables] Add tests for visibility: collapse, visibility:hidden #6199

Closed
wants to merge 9 commits into from
Closed

[css-tables] Add tests for visibility: collapse, visibility:hidden #6199

wants to merge 9 commits into from

Conversation

joysyu
Copy link

@joysyu joysyu commented Jun 9, 2017 •
edited by wpt-pr-bot

No description provided.

@w3c-bots
Copy link

w3c-bots commented Jun 9, 2017 •
edited

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 0a9a7ba
Using browser at version BuildID 20170720100139; SourceStamp 0985725c848ec0cfc6f2f3c3a5aa3d71321e7620
Starting 10 test iterations
All results were stable

All results

22 tests ran
/css/css-tables-3/visibility-collapse-rowspan-005.html
Subtest Results Messages
FAIL
/css/css-tables-3/visibility-collapse-col-001.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width PASS
/css/css-tables-3/visibility-collapse-col-002.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width PASS
/css/css-tables-3/visibility-collapse-col-003.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width PASS
/css/css-tables-3/visibility-collapse-col-004.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width PASS
/css/css-tables-3/visibility-collapse-non-rowcol-001.html
Subtest Results Messages
OK
table width is unchanged PASS
table height is unchanged PASS
td visibility:collapse has no effect on td width PASS
td visibility:collapse has no effect on td height PASS
span visibility:collapse has no effect on span width PASS
span visibility:collapse has no effect on span height PASS
/css/css-tables-3/visibility-collapse-row-001.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden PASS
/css/css-tables-3/visibility-collapse-row-002-dynamic.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden PASS
/css/css-tables-3/visibility-collapse-row-003-dynamic.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden PASS
/css/css-tables-3/visibility-collapse-row-group-001.html
Subtest Results Messages
OK
row group visibility:collapse doesn't change table width PASS
row group visibility:collapse changes table height PASS
the first row should be collapsed PASS
the second row should be collapsed PASS
the third row stays the same PASS
/css/css-tables-3/visibility-collapse-row-group-002.html
Subtest Results Messages
OK
row group visibility:collapse doesn't change table width PASS
row group visibility:collapse changes table height PASS
/css/css-tables-3/visibility-collapse-rowspan-001.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
spanning row visibility:collapse doesn't change height in this case PASS
/css/css-tables-3/visibility-collapse-rowspan-002-border-separate.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
fourth row stays the same height PASS
third row stays the same height PASS
spanning row visibility:collapse makes row height 0 PASS
first row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height PASS
/css/css-tables-3/visibility-collapse-rowspan-002.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
fourth row stays the same height PASS
third row stays the same height PASS
spanning row visibility:collapse makes row height 0 PASS
first row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height PASS
/css/css-tables-3/visibility-collapse-rowspan-003-border-separate.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
collapsed row has zero height PASS
first row height doesn't change PASS
second row height doesn't change PASS
fourth row height doesn't change PASS
fifth row height doesn't change PASS
/css/css-tables-3/visibility-collapse-rowspan-003.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
collapsed row has zero height PASS
first row height doesn't change PASS
second row height doesn't change PASS
fourth row height doesn't change PASS
fifth row height doesn't change PASS
/css/css-tables-3/visibility-collapse-rowspan-004-dynamic.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
when third row is collapsed, first row stays the same height PASS
when third row is collapsed, second row stays the same height PASS
third row visibility:collapse makes row height 0 PASS
when third row is collapsed, fourth row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height PASS
when third row is visible, first row stays the same height PASS
when third row is visible, second row stays the same height PASS
when third row is visible, third row stays the same height PASS
when third row is visible, fourth row stays the same height PASS
when third row is visible, fifth row stays the same height PASS
when third row is visible, spanning cell stays the same height PASS
(2nd collapse) spanning row visibility:collapse doesn't change table width PASS
when third row is collapsed again, first row stays the same height PASS
when third row is collapsed again, second row stays the same height PASS
(2nd collapse) third row visibility:collapse makes row height 0 PASS
when third row is collapsed again, fourth row stays the same height PASS
(2nd collapse) spanning cell shrinks to sum of remaining three rows' height PASS
/css/css-tables-3/visibility-hidden-col-001.html
Subtest Results Messages
OK
visibility:hidden doesn't change table height PASS
visibility:hidden doesn't change table width PASS
/css/css-tables-3/visibility-hidden-nested-001.html
Subtest Results Messages
OK
table visibility:hidden doesn't change table height PASS
table visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change row width PASS
row visibility:hidden doesn't change row height PASS
cell visibility:hidden doesn't change cell width PASS
cell visibility:hidden doesn't change cell height PASS
span visibility:hidden doesn't change span width PASS
span visibility:hidden doesn't change span height PASS
/css/css-tables-3/visibility-hidden-nested-002.html
Subtest Results Messages
OK
table visibility:hidden doesn't change table height PASS
table visibility:hidden doesn't change table width PASS
hidden and visible cells should have same height PASS
hidden and visible cells should have same width PASS
/css/css-tables-3/visibility-hidden-row-001.html
Subtest Results Messages
OK
row visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change table height PASS
Table height is 222px PASS
/css/css-tables-3/visibility-hidden-row-002.html
Subtest Results Messages
OK
row visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change table height PASS
Table height is 222px PASS

@w3c-bots
Copy link

w3c-bots commented Jun 9, 2017 •
edited

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 0a9a7ba
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

22 tests ran
/css/css-tables-3/visibility-collapse-col-001.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width FAIL assert_equals: col visibility:collapse changes table width expected 116 but got 222
/css/css-tables-3/visibility-collapse-col-002.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width FAIL assert_equals: col visibility:collapse changes table width expected 10 but got 222
/css/css-tables-3/visibility-collapse-col-003.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width FAIL assert_equals: col visibility:collapse changes table width expected 116 but got 222
/css/css-tables-3/visibility-collapse-col-004.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width FAIL assert_equals: col visibility:collapse changes table width expected 116 but got 222
/css/css-tables-3/visibility-collapse-non-rowcol-001.html
Subtest Results Messages
OK
table width is unchanged PASS
table height is unchanged PASS
td visibility:collapse has no effect on td width PASS
td visibility:collapse has no effect on td height PASS
span visibility:collapse has no effect on span width PASS
span visibility:collapse has no effect on span height PASS
/css/css-tables-3/visibility-collapse-row-001.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden FAIL assert_equals: row visibility:collapse changes table height, unlike visibility:hidden expected 116 but got 222
/css/css-tables-3/visibility-collapse-row-002-dynamic.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden FAIL assert_equals: row visibility:collapse changes table height, unlike visibility:hidden expected 116 but got 222
/css/css-tables-3/visibility-collapse-row-003-dynamic.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden FAIL assert_equals: row visibility:collapse changes table height, unlike visibility:hidden expected 116 but got 222
/css/css-tables-3/visibility-collapse-row-group-001.html
Subtest Results Messages
OK
row group visibility:collapse doesn't change table width PASS
row group visibility:collapse changes table height FAIL assert_equals: row group visibility:collapse changes table height expected 116 but got 328
the first row should be collapsed FAIL assert_equals: the first row should be collapsed expected 0 but got 106
the second row should be collapsed FAIL assert_equals: the second row should be collapsed expected 0 but got 106
the third row stays the same PASS
/css/css-tables-3/visibility-collapse-row-group-002.html
Subtest Results Messages
OK
row group visibility:collapse doesn't change table width PASS
row group visibility:collapse changes table height FAIL assert_equals: row group visibility:collapse changes table height expected 116 but got 328
/css/css-tables-3/visibility-collapse-rowspan-001.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
spanning row visibility:collapse doesn't change height in this case PASS
/css/css-tables-3/visibility-collapse-rowspan-002-border-separate.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
fourth row stays the same height PASS
third row stays the same height PASS
spanning row visibility:collapse makes row height 0 FAIL assert_equals: spanning row visibility:collapse makes row height 0 expected 0 but got 30
first row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 90 but got 120
/css/css-tables-3/visibility-collapse-rowspan-002.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
fourth row stays the same height PASS
third row stays the same height PASS
spanning row visibility:collapse makes row height 0 FAIL assert_equals: spanning row visibility:collapse makes row height 0 expected 0 but got 29
first row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 87 but got 116
/css/css-tables-3/visibility-collapse-rowspan-003-border-separate.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
collapsed row has zero height FAIL assert_equals: collapsed row has zero height expected 0 but got 30
first row height doesn't change PASS
second row height doesn't change PASS
fourth row height doesn't change PASS
fifth row height doesn't change PASS
/css/css-tables-3/visibility-collapse-rowspan-003.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
collapsed row has zero height FAIL assert_equals: collapsed row has zero height expected 0 but got 29
first row height doesn't change PASS
second row height doesn't change PASS
fourth row height doesn't change PASS
fifth row height doesn't change PASS
/css/css-tables-3/visibility-collapse-rowspan-004-dynamic.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
when third row is collapsed, first row stays the same height PASS
when third row is collapsed, second row stays the same height PASS
third row visibility:collapse makes row height 0 FAIL assert_equals: third row visibility:collapse makes row height 0 expected 0 but got 29
when third row is collapsed, fourth row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 116 but got 145
when third row is visible, first row stays the same height PASS
when third row is visible, second row stays the same height PASS
when third row is visible, third row stays the same height PASS
when third row is visible, fourth row stays the same height PASS
when third row is visible, fifth row stays the same height PASS
when third row is visible, spanning cell stays the same height PASS
(2nd collapse) spanning row visibility:collapse doesn't change table width PASS
when third row is collapsed again, first row stays the same height PASS
when third row is collapsed again, second row stays the same height PASS
(2nd collapse) third row visibility:collapse makes row height 0 FAIL assert_equals: (2nd collapse) third row visibility:collapse makes row height 0 expected 0 but got 29
when third row is collapsed again, fourth row stays the same height PASS
(2nd collapse) spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: (2nd collapse) spanning cell shrinks to sum of remaining three rows' height expected 116 but got 145
/css/css-tables-3/visibility-hidden-col-001.html
Subtest Results Messages
OK
visibility:hidden doesn't change table height PASS
visibility:hidden doesn't change table width PASS
/css/css-tables-3/visibility-hidden-nested-001.html
Subtest Results Messages
OK
table visibility:hidden doesn't change table height PASS
table visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change row width PASS
row visibility:hidden doesn't change row height PASS
cell visibility:hidden doesn't change cell width PASS
cell visibility:hidden doesn't change cell height PASS
span visibility:hidden doesn't change span width PASS
span visibility:hidden doesn't change span height PASS
/css/css-tables-3/visibility-hidden-nested-002.html
Subtest Results Messages
OK
table visibility:hidden doesn't change table height PASS
table visibility:hidden doesn't change table width PASS
hidden and visible cells should have same height PASS
hidden and visible cells should have same width PASS
/css/css-tables-3/visibility-hidden-row-001.html
Subtest Results Messages
OK
row visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change table height PASS
Table height is 222px PASS
/css/css-tables-3/visibility-hidden-row-002.html
Subtest Results Messages
OK
row visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change table height PASS
Table height is 222px PASS
/css/css-tables-3/visibility-collapse-rowspan-005.html
Subtest Results Messages
FAIL

@w3c-bots
Copy link

w3c-bots commented Jun 9, 2017 •
edited

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 0a9a7ba
Using browser at version 61.0.3159.5 dev
Starting 10 test iterations
All results were stable

All results

22 tests ran
/css/css-tables-3/visibility-collapse-col-001.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width FAIL assert_equals: col visibility:collapse changes table width expected 116 but got 222
/css/css-tables-3/visibility-collapse-col-002.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width FAIL assert_equals: col visibility:collapse changes table width expected 10 but got 222
/css/css-tables-3/visibility-collapse-col-003.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width FAIL assert_equals: col visibility:collapse changes table width expected 116 but got 222
/css/css-tables-3/visibility-collapse-col-004.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width FAIL assert_equals: col visibility:collapse changes table width expected 116 but got 222
/css/css-tables-3/visibility-collapse-non-rowcol-001.html
Subtest Results Messages
OK
table width is unchanged PASS
table height is unchanged PASS
td visibility:collapse has no effect on td width PASS
td visibility:collapse has no effect on td height PASS
span visibility:collapse has no effect on span width PASS
span visibility:collapse has no effect on span height PASS
/css/css-tables-3/visibility-collapse-row-001.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden FAIL assert_equals: row visibility:collapse changes table height, unlike visibility:hidden expected 116 but got 222
/css/css-tables-3/visibility-collapse-row-002-dynamic.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden FAIL assert_equals: row visibility:collapse changes table height, unlike visibility:hidden expected 116 but got 222
/css/css-tables-3/visibility-collapse-row-003-dynamic.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden FAIL assert_equals: row visibility:collapse changes table height, unlike visibility:hidden expected 116 but got 307;assert_equals: row visibility:collapse changes table height, unlike visibility:hidden expected 116 but got 222
/css/css-tables-3/visibility-collapse-row-group-001.html
Subtest Results Messages
OK
row group visibility:collapse doesn't change table width PASS
row group visibility:collapse changes table height FAIL assert_equals: row group visibility:collapse changes table height expected 116 but got 328
the first row should be collapsed FAIL assert_equals: the first row should be collapsed expected 0 but got 106
the second row should be collapsed FAIL assert_equals: the second row should be collapsed expected 0 but got 106
the third row stays the same PASS
/css/css-tables-3/visibility-collapse-row-group-002.html
Subtest Results Messages
OK
row group visibility:collapse doesn't change table width PASS
row group visibility:collapse changes table height FAIL assert_equals: row group visibility:collapse changes table height expected 116 but got 328
/css/css-tables-3/visibility-collapse-rowspan-001.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
spanning row visibility:collapse doesn't change height in this case PASS
/css/css-tables-3/visibility-collapse-rowspan-002-border-separate.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
fourth row stays the same height PASS
third row stays the same height PASS
spanning row visibility:collapse makes row height 0 FAIL assert_equals: spanning row visibility:collapse makes row height 0 expected 0 but got 30
first row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 90 but got 120
/css/css-tables-3/visibility-collapse-rowspan-002.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
fourth row stays the same height PASS
third row stays the same height PASS
spanning row visibility:collapse makes row height 0 FAIL assert_equals: spanning row visibility:collapse makes row height 0 expected 0 but got 29
first row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 87 but got 116
/css/css-tables-3/visibility-collapse-rowspan-003-border-separate.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
collapsed row has zero height FAIL assert_equals: collapsed row has zero height expected 0 but got 30
first row height doesn't change PASS
second row height doesn't change PASS
fourth row height doesn't change PASS
fifth row height doesn't change PASS
/css/css-tables-3/visibility-collapse-rowspan-003.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
collapsed row has zero height FAIL assert_equals: collapsed row has zero height expected 0 but got 29
first row height doesn't change PASS
second row height doesn't change PASS
fourth row height doesn't change PASS
fifth row height doesn't change PASS
/css/css-tables-3/visibility-collapse-rowspan-004-dynamic.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
when third row is collapsed, first row stays the same height PASS
when third row is collapsed, second row stays the same height PASS
third row visibility:collapse makes row height 0 FAIL assert_equals: third row visibility:collapse makes row height 0 expected 0 but got 29
when third row is collapsed, fourth row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 116 but got 145
when third row is visible, first row stays the same height PASS
when third row is visible, second row stays the same height PASS
when third row is visible, third row stays the same height PASS
when third row is visible, fourth row stays the same height PASS
when third row is visible, fifth row stays the same height PASS
when third row is visible, spanning cell stays the same height PASS
(2nd collapse) spanning row visibility:collapse doesn't change table width PASS
when third row is collapsed again, first row stays the same height PASS
when third row is collapsed again, second row stays the same height PASS
(2nd collapse) third row visibility:collapse makes row height 0 FAIL assert_equals: (2nd collapse) third row visibility:collapse makes row height 0 expected 0 but got 29
when third row is collapsed again, fourth row stays the same height PASS
(2nd collapse) spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: (2nd collapse) spanning cell shrinks to sum of remaining three rows' height expected 116 but got 145
/css/css-tables-3/visibility-hidden-col-001.html
Subtest Results Messages
OK
visibility:hidden doesn't change table height PASS
visibility:hidden doesn't change table width PASS
/css/css-tables-3/visibility-hidden-nested-001.html
Subtest Results Messages
OK
table visibility:hidden doesn't change table height PASS
table visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change row width PASS
row visibility:hidden doesn't change row height PASS
cell visibility:hidden doesn't change cell width PASS
cell visibility:hidden doesn't change cell height PASS
span visibility:hidden doesn't change span width PASS
span visibility:hidden doesn't change span height PASS
/css/css-tables-3/visibility-hidden-nested-002.html
Subtest Results Messages
OK
table visibility:hidden doesn't change table height PASS
table visibility:hidden doesn't change table width PASS
hidden and visible cells should have same height PASS
hidden and visible cells should have same width PASS
/css/css-tables-3/visibility-hidden-row-001.html
Subtest Results Messages
OK
row visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change table height PASS
Table height is 222px PASS
/css/css-tables-3/visibility-hidden-row-002.html
Subtest Results Messages
OK
row visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change table height PASS
Table height is 222px PASS
/css/css-tables-3/visibility-collapse-rowspan-005.html
Subtest Results Messages
FAIL

@w3c-bots
Copy link

w3c-bots commented Jun 9, 2017 •
edited

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 0a9a7ba
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

22 tests ran
/css/css-tables-3/visibility-collapse-col-001.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width PASS
/css/css-tables-3/visibility-collapse-col-002.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width PASS
/css/css-tables-3/visibility-collapse-col-003.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width PASS
/css/css-tables-3/visibility-collapse-col-004.html
Subtest Results Messages
OK
col visibility:collapse doesn't change table height PASS
col visibility:collapse changes table width PASS
/css/css-tables-3/visibility-collapse-non-rowcol-001.html
Subtest Results Messages
OK
table width is unchanged PASS
table height is unchanged PASS
td visibility:collapse has no effect on td width PASS
td visibility:collapse has no effect on td height PASS
span visibility:collapse has no effect on span width PASS
span visibility:collapse has no effect on span height PASS
/css/css-tables-3/visibility-collapse-row-001.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden PASS
/css/css-tables-3/visibility-collapse-row-002-dynamic.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden PASS
/css/css-tables-3/visibility-collapse-row-003-dynamic.html
Subtest Results Messages
OK
row visibility:collapse doesn't change table width, unlike display:none PASS
row visibility:collapse changes table height, unlike visibility:hidden PASS
/css/css-tables-3/visibility-collapse-row-group-001.html
Subtest Results Messages
OK
row group visibility:collapse doesn't change table width PASS
row group visibility:collapse changes table height PASS
the first row should be collapsed PASS
the second row should be collapsed PASS
the third row stays the same PASS
/css/css-tables-3/visibility-collapse-row-group-002.html
Subtest Results Messages
OK
row group visibility:collapse doesn't change table width PASS
row group visibility:collapse changes table height PASS
/css/css-tables-3/visibility-collapse-rowspan-001.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
spanning row visibility:collapse doesn't change height in this case PASS
/css/css-tables-3/visibility-collapse-rowspan-002-border-separate.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
fourth row stays the same height PASS
third row stays the same height PASS
spanning row visibility:collapse makes row height 0 PASS
first row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 90 but got 122
/css/css-tables-3/visibility-collapse-rowspan-002.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
fourth row stays the same height PASS
third row stays the same height PASS
spanning row visibility:collapse makes row height 0 PASS
first row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 87 but got 118
/css/css-tables-3/visibility-collapse-rowspan-003-border-separate.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
collapsed row has zero height PASS
first row height doesn't change PASS
second row height doesn't change PASS
fourth row height doesn't change PASS
fifth row height doesn't change PASS
/css/css-tables-3/visibility-collapse-rowspan-003.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
collapsed row has zero height PASS
first row height doesn't change PASS
second row height doesn't change PASS
fourth row height doesn't change PASS
fifth row height doesn't change PASS
/css/css-tables-3/visibility-collapse-rowspan-004-dynamic.html
Subtest Results Messages
OK
spanning row visibility:collapse doesn't change table width PASS
when third row is collapsed, first row stays the same height PASS
when third row is collapsed, second row stays the same height PASS
third row visibility:collapse makes row height 0 PASS
when third row is collapsed, fourth row stays the same height PASS
spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: spanning cell shrinks to sum of remaining three rows' height expected 116 but got 147
when third row is visible, first row stays the same height PASS
when third row is visible, second row stays the same height PASS
when third row is visible, third row stays the same height PASS
when third row is visible, fourth row stays the same height PASS
when third row is visible, fifth row stays the same height PASS
when third row is visible, spanning cell stays the same height PASS
(2nd collapse) spanning row visibility:collapse doesn't change table width PASS
when third row is collapsed again, first row stays the same height PASS
when third row is collapsed again, second row stays the same height PASS
(2nd collapse) third row visibility:collapse makes row height 0 PASS
when third row is collapsed again, fourth row stays the same height PASS
(2nd collapse) spanning cell shrinks to sum of remaining three rows' height FAIL assert_equals: (2nd collapse) spanning cell shrinks to sum of remaining three rows' height expected 116 but got 147
/css/css-tables-3/visibility-hidden-col-001.html
Subtest Results Messages
OK
visibility:hidden doesn't change table height PASS
visibility:hidden doesn't change table width PASS
/css/css-tables-3/visibility-hidden-nested-001.html
Subtest Results Messages
OK
table visibility:hidden doesn't change table height PASS
table visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change row width PASS
row visibility:hidden doesn't change row height PASS
cell visibility:hidden doesn't change cell width PASS
cell visibility:hidden doesn't change cell height PASS
span visibility:hidden doesn't change span width PASS
span visibility:hidden doesn't change span height PASS
/css/css-tables-3/visibility-hidden-nested-002.html
Subtest Results Messages
OK
table visibility:hidden doesn't change table height PASS
table visibility:hidden doesn't change table width PASS
hidden and visible cells should have same height PASS
hidden and visible cells should have same width PASS
/css/css-tables-3/visibility-hidden-row-001.html
Subtest Results Messages
OK
row visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change table height PASS
Table height is 222px PASS
/css/css-tables-3/visibility-hidden-row-002.html
Subtest Results Messages
OK
row visibility:hidden doesn't change table width PASS
row visibility:hidden doesn't change table height PASS
Table height is 222px PASS
/css/css-tables-3/visibility-collapse-rowspan-005.html
Subtest Results Messages
PASS

@sideshowbarker
Copy link
Contributor

w3c-test:mirror

Joy Yu and others added 2 commits June 12, 2017 16:36
gregwhitworth
gregwhitworth requested changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@gregwhitworth gregwhitworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good @joysu. One thing that I'm not seeing is any testing of replaced elements nor dynamic modifications. Knowing that Edge currently has a bug in invalidation it would be useful to ensure that we're mimicking a user invalidation of some type. Thanks.

css/work-in-progress/microsoft/css-tables/visibility-collapse-col-002.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use generate_tests() - we are actively discouraging it. I know that we have throughout the testcases that are currently in WIP and you probably got that pattern from us. To fix this, use a for loop and then assert_equals(). You can see more on this on the WPT Documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, I know that I initially spoke with @davidsgrogan and we planned to put them in WIP, and he had the good point of just putting them into CSS3 tables path. We should begin on doing this, the path is css/css-tables-3. I won't block on this as @FremyCompany or myself will move them a bit later. I also think it's imperative that we resolve on the spec language for the sizing and painting of visibility: collapse within issue 478. @FremyCompany and myself will try to land this, so if you could please stage these in the actual tables folder that would be greatly appreciated, but not required for my sign off. Thanks!

css/work-in-progress/microsoft/css-tables/visibility-collapse-col-003.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

css/work-in-progress/microsoft/css-tables/visibility-collapse-non-rowcol-001.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

css/work-in-progress/microsoft/css-tables/visibility-collapse-row-002.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

css/work-in-progress/microsoft/css-tables/visibility-collapse-row-003.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

css/work-in-progress/microsoft/css-tables/visibility-hidden-col-001.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

css/work-in-progress/microsoft/css-tables/visibility-hidden-nested-001.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

css/work-in-progress/microsoft/css-tables/visibility-hidden-nested-002.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

css/work-in-progress/microsoft/css-tables/visibility-hidden-row-001.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

css/work-in-progress/microsoft/css-tables/visibility-hidden-row-002.html Outdated
</main>

<script>
generate_tests(assert_equals, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

@wpt-pr-bot wpt-pr-bot requested a review from dbaron June 23, 2017 22:12
@joysyu
Copy link
Author

joysyu commented Jun 23, 2017 •
edited

Thanks so much @gregwhitworth for the code review! In addition to moving the tests to css-tables-3 and taking out generate_tests, I added three row span tests. I also added three tests with dynamic changes: visibility-collapse-col-004.html, visibility-collapse-row-004.html, and visibility-collapse-row-005.html (this also collapses an image). I'm not too sure what you mean by replaced elements; does collapsing an image count?

@joysyu
Copy link
Author

joysyu commented Jun 23, 2017

Also, visibility-collapse-nested-001.html addresses the Edge bug :)

@wpt-pr-bot wpt-pr-bot requested a review from frivoal June 26, 2017 23:36
@joysyu joysyu force-pushed the visibilityAndCollapseTests branch from 8f34bba to 615bd55 Compare June 26, 2017 23:38
@joysyu joysyu force-pushed the visibilityAndCollapseTests branch from 615bd55 to 403532f Compare June 27, 2017 17:28
gregwhitworth
gregwhitworth requested changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@gregwhitworth gregwhitworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joysyu Overall this is really great. We're almost there, a few more changes as I tested them in FF/Edge and cross compared with the spec. Thank you so much - great work!

css/css-tables-3/visibility-collapse-nested-001.html Outdated
<script src='/resources/testharnessreport.js'></script>
<link rel='stylesheet' href='../support/base.css' />
<link rel="author" title="Joy Yu" href="mailto:joysyu@mit.edu">
<link rel="help" href="https://drafts.csswg.org/css-x-tables-3/#computing-the-x-table-height">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an x in here - this makes the url fail. Seems like a find/replace issue as the hash has -x- as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

css/css-tables-3/visibility-collapse-nested-001.html Outdated
</x-table>
<p>
Row 1 and Row 2 are both visibility:visible. Row 1 and Row 2 are within the same row group
which is visibility: collapse. Rows 1 and 2 should not be visible.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test needs to be a bit more complex as Edge technically passes this as the table is sized to correct height, but row 1 & 2 are visible in Edge and this test didn't catch it.

css/css-tables-3/visibility-collapse-row-003.html Outdated
],
[
document.getElementById('two').offsetHeight,
116,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, this test doesn't catch that Edge paints row 1 & 2 over top of 3. Additionally, if you're actually testing that setting collapse on row group doesn't make rows appear, then change the file name to something like ...-row-group-YYY.html

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is actually the exact same test as visibility-collapse-nested-001, so I've deleted that and fixed this test to be more complex to catch Edge's bug. Thanks for catching this!

css/css-tables-3/visibility-collapse-row-005.html Outdated
@@ -0,0 +1,89 @@
<!doctype html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add dynamic to the end of this file name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

css/css-tables-3/visibility-collapse-row-005.html Outdated
</main>

<script>
colgroup = document.getElementById("collapse");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are getting a row, not a colgroup - change the variable name accordingly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

css/css-tables-3/visibility-collapse-rowspan-002.html
@@ -0,0 +1,105 @@
<!doctype html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please create a copy of rowspan-002 & rowspan-003 and create ones that are in border-collapse: seperate mode? Make sure this is reflected in the name so it's easy to differentiate the tests.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gsnedders gsnedders removed their request for review July 11, 2017 16:10
@joysyu joysyu force-pushed the visibilityAndCollapseTests branch from f7bfa83 to c41c565 Compare July 17, 2017 22:51
@joysyu joysyu force-pushed the visibilityAndCollapseTests branch from c41c565 to 706eb44 Compare July 17, 2017 22:56
@joysyu
Copy link
Author

joysyu commented Jul 17, 2017

Thank you @gregwhitworth! I've made the changes :) Let me know what you think!

@joysyu joysyu force-pushed the visibilityAndCollapseTests branch from 52dd95d to ad5b42d Compare July 20, 2017 21:45
@gsnedders
Copy link
Member

@gregwhitworth @FremyCompany ping?

@davidsgrogan
Copy link
Member

Joy eventually landed these through chromium's sync. This can be closed.

@gsnedders gsnedders closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregwhitworth gregwhitworth gregwhitworth requested changes

@FremyCompany FremyCompany Awaiting requested review from FremyCompany

@dbaron dbaron Awaiting requested review from dbaron

@frivoal frivoal Awaiting requested review from frivoal

@gsnedders gsnedders Awaiting requested review from gsnedders

Assignees
No one assigned
Labels
css-tables support wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joysyu @w3c-bots @sideshowbarker @gsnedders @davidsgrogan @gregwhitworth @wpt-pr-bot