Initial manual tests for basic card #6817
Conversation
|
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Build BROKENStarted: 2017-08-11 07:46:36 View more information about this build on: |
marcoscaceres
force-pushed
the
basic-card
branch
from
502b3ce
to
5301751
Compare
Build PASSEDStarted: 2017-10-09 10:16:00 View more information about this build on: |
| await request.canMakePayment(), | ||
| `canMakePaymentPromise should be false` | ||
| ); | ||
| }, `Must return false when the PMI is not supported at by the user agent.`); |
There was a problem hiding this comment.
This and the other tests fail as such in Chrome:
promise_test: Unhandled rejection with value: object "TypeError: Failed to construct 'PaymentRequest': The provided value cannot be converted to a sequence."
Chrome bug, or test bug?
There was a problem hiding this comment.
Chrome bug in this case.
There was a problem hiding this comment.
OK, thanks for poking at it with a test!
|
I came across this because of status:needs-owners label. Can you add OWNERS? |
|
@foolip owners are now there. Will check other issue. |
Manual tests for various forms of BasicCardRequest.
marcoscaceres
force-pushed
the
basic-card
branch
from
290f2de
to
ded4148
Compare
|
@rsolomakhin ... should probably add you to OWNERS too. If you have time, could you please take a look at these tests? It's been a while since I wrote/ran them 🙃 |
| await request.canMakePayment(), | ||
| `canMakePaymentPromise should be false` | ||
| ); | ||
| }, `Must return false when the PMI is not supported at by the user agent.`); |
There was a problem hiding this comment.
OK, thanks for poking at it with a test!
|
I added @rsolomakhin in #7640 and merged both. @rsolomakhin, can you file a Chromium bug for the failing test mentioned above? |
Manual tests for various forms of BasicCardRequest.
No description provided.