Avoid visual comparisons with lang="ja-jp" #6926
Conversation
wpt-pr-bot
requested review from
bert-github,
chenxix,
dbaron,
fantasai,
frivoal,
gsnedders,
kojiishi,
kwkbtr and
svgeesus
Build PASSEDStarted: 2017-08-18 00:01:48 View more information about this build on: |
Build PASSEDStarted: 2017-08-17 20:28:37 View more information about this build on: |
|
Or it should be rewritten to not use the As an aside, I can't see anything in any spec that would seem to permit what browsers actually do with language-specific generics; spec bug forthcoming. |
|
For now, if we want to have such consistency, more extensive changes would be needed (please see revised commit). |
The reference file `attribute-value-selector-001-ref.xht` does not specify `lang="ja-jp"` on the first `div` while this file does. This causes the two pages to look different because a Japanese font is selected in this file. Changing "ja-jp" to a language written in Latin letters, "fr-fr", avoids this problem.
|
w3c-test:mirror |
|
@dbaron's comment above looks reasonable, was that addressed? I can see only 1 commit. |
|
Yes, it has been addressed. I applied the same language tags to the reference and all three tests that use it. |
Build PASSEDStarted: 2017-08-18 00:01:48 Failing Jobs
View more information about this build on: |
The reference file `attribute-value-selector-001-ref.xht` does not specify `lang="ja-jp"` on the first `div` while this file does. This causes the two pages to look different because a Japanese font is selected in this file. Changing "ja-jp" to a language written in Latin letters, "fr-fr", avoids this problem.
The reference file `attribute-value-selector-001-ref.xht` does not specify `lang="ja-jp"` on the first `div` while this file does. This causes the two pages to look different because a Japanese font is selected in this file. Changing "ja-jp" to a language written in Latin letters, "fr-fr", avoids this problem.
The reference file
attribute-value-selector-001-ref.xhtdoes not specifylang="ja-jp"on the firstdivwhile this file does. This causes the two pages to look different because a Japanese font is selected in this file. Changing "ja-jp" to a language written in Latin letters, "fr-fr", avoids this problem.