New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission/unipro custom elements #715
Submission/unipro custom elements #715
Conversation
…ctored to have testEach property
'.-frame', '_frame', 'x-f!rame', 'x-:frame' | ||
]; | ||
var invalidNames = ['xframe', 'x_frame', 'x.frame', 'x1frame', '-xframe', '1-frame', '1x-frame', | ||
'.-frame', '_frame', 'x-f!rame', 'x-:frame']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
' should not be indented <= the square bracket if you're wrapping this way. There's weird wrapping of array literals below, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
// NCName ::= (Letter | '_') (NCNameChar)* | ||
// NCNameChar ::= Letter | Digit | '.' | '-' | '_' | CombiningChar | Extender | ||
// Letter ::= BaseChar | Ideographic | ||
// NCName ::= (Letter | '_') (NCNameChar)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's OK if the ::= s line up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Pull request to merge additional changes to Concepts tests