Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpt] Fix response-cancel-stream.html flakiness #7233

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 4, 2017

Currently the test expects that one one read call makes the response
body stream closed, which is not always true. With this change, the test
reads the body stream till the end.

Bug: 603396
Change-Id: I41b6fbb465945702c6374835f2b4f632a1bc2c5c
Reviewed-on: https://chromium-review.googlesource.com/648869
Commit-Queue: Yutaka Hirano yhirano@chromium.org
Reviewed-by: Adam Rice ricea@chromium.org
Cr-Commit-Position: refs/heads/master@{#499445}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@w3c-bots
Copy link

w3c-bots commented Sep 4, 2017

Build PASSED

Started: 2017-09-04 07:13:33
Finished: 2017-09-04 07:18:01

Failing Jobs

  • chrome:unstable

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-I41b6fbb465945702c6374835f2b4f632a1bc2c5c branch 3 times, most recently from 7521c99 to cbcad5a Compare September 4, 2017 04:17
Currently the test expects that one one read call makes the response
body stream closed, which is not always true. With this change, the test
reads the body stream till the end.

Bug: 603396
Change-Id: I41b6fbb465945702c6374835f2b4f632a1bc2c5c
Reviewed-on: https://chromium-review.googlesource.com/648869
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499445}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-I41b6fbb465945702c6374835f2b4f632a1bc2c5c branch from cbcad5a to 5d2a15b Compare September 4, 2017 07:02
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a8da658 into master Sep 4, 2017
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-I41b6fbb465945702c6374835f2b4f632a1bc2c5c branch September 4, 2017 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants