Implement Dismiss Alert tests for WPT wdspec tests #7353
Conversation
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
lukeis,
mjzffr and
shs96c
Build PENDINGStarted: None Failing Jobs
View more information about this build on: |
|
Testing webdriver dismiss alert spec. |
|
|
||
| def test_dismiss_confirm(session): | ||
| # 18.1 step 3 | ||
| session.execute_script("window.confirm(\"Hello\");") |
There was a problem hiding this comment.
window.confirm returns a boolean based on whether it is accepted or dismissed. You should store that value on the window global and validate it.
|
|
||
| def test_dismiss_prompt(session): | ||
| # 18.1 step 3 | ||
| session.execute_script("window.prompt(\"Enter Your Name: \", \"Federer\");") |
There was a problem hiding this comment.
window.prompt returns an empty string if accepted without value or null otherwise. Set this value on the window global to verify that the prompt gets dismissed.
| # 18.1 step 3 | ||
| session.execute_script("window.result = window.prompt(\"Enter Your Name: \", \"Federer\");") | ||
| response = dismiss_alert(session) | ||
| assert None == session.execute_script("return window.result") |
There was a problem hiding this comment.
This should be assert session.execute_script("return window.result") is None.
| session.execute_script("window.result = window.prompt(\"Enter Your Name: \", \"Federer\");") | ||
| response = dismiss_alert(session) | ||
| assert None == session.execute_script("return window.result") | ||
| assert_success(response) |
There was a problem hiding this comment.
This should come before the assertion?
| session.execute_script("window.result = window.confirm(\"Hello\");") | ||
| response = dismiss_alert(session) | ||
| assert False == session.execute_script("return window.result;") | ||
| assert_success(response) |
There was a problem hiding this comment.
This should come before the assertion?
| # 18.1 step 3 | ||
| session.execute_script("window.result = window.confirm(\"Hello\");") | ||
| response = dismiss_alert(session) | ||
| assert False == session.execute_script("return window.result;") |
There was a problem hiding this comment.
Should be session.execute_script("return window.result") is False.
…ing value of dialog
No description provided.