Reland "Rename CSS scroll-boundary-behavior to overscroll-behavior" #7974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 25, 2017
Build PASSEDStarted: 2017-10-26 01:31:59 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-738295
branch
2 times, most recently
from
a236476
to
23d7f15
Compare
This is a reland of 74e8a0f74fc589a58258655f59aa7f1efa666155 The only change is in third_party/WebKit/Source/core/BUILD.gn where an outdated generated file was updated with a new name. Original change's description: > Rename CSS scroll-boundary-behavior to overscroll-behavior > > The name change was decided here [1]. > > This is the minimal patch to change the publicly exposed CSS property. > It is intentionally small to make it easier to merge with M63. So, > internally Blink and content still use ScrollBoundaryBehavior name which will > be updated in the follow up patch larger patch. > > > [1] https://github.com/WICG/scroll-boundary-behavior/issues/24 > > Bug: 776776 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Iaa6ad62253ed7fe9ed7f0ee9865ffda852b17801 > Reviewed-on: https://chromium-review.googlesource.com/737090 > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > Reviewed-by: Sandra Sun <sunyunjia@chromium.org> > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#511493} Bug: 776776 TBR: dglazkov@chromium.org, pdr@chromium.org Change-Id: If9198d1eb0c7d0a4a4955a40e03e456f21275589 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/738295 Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#511677}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-738295
branch
from
23d7f15
to
480ae39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of 74e8a0f74fc589a58258655f59aa7f1efa666155
The only change is in third_party/WebKit/Source/core/BUILD.gn
where an outdated generated file was updated with a new name.
Original change's description:
Bug: 776776
TBR: dglazkov@chromium.org, pdr@chromium.org
Change-Id: If9198d1eb0c7d0a4a4955a40e03e456f21275589
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/738295
Reviewed-by: Majid Valipour majidvp@chromium.org
Commit-Queue: Majid Valipour majidvp@chromium.org
Cr-Commit-Position: refs/heads/master@{#511677}