Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service worker: Remove unregister.html test that is already in WPT. #8062

Merged
merged 1 commit into from Nov 3, 2017

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 3, 2017

This test is nearly identical to unregister.https.html. The only differences
are the test uses waitUntil() in the message event and it uses a non-existent
page for a scope instead of a blank page. Remove unregister.html and add
waitUntil() calls to unregister.https.html.

Bug: 452910, 688116
Change-Id: I41c42ae090837eceaf90d3b3c7c4f6383c4ef821
Reviewed-on: https://chromium-review.googlesource.com/753202
Reviewed-by: Marijn Kruisselbrink mek@chromium.org
Commit-Queue: Matt Falkenhagen falken@chromium.org
Cr-Commit-Position: refs/heads/master@{#513927}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@w3c-bots
Copy link

w3c-bots commented Nov 3, 2017

Build PASSED

Started: 2017-11-03 22:22:01
Finished: 2017-11-03 22:25:02

View more information about this build on:

This test is nearly identical to unregister.https.html. The only differences
are the test uses waitUntil() in the message event and it uses a non-existent
page for a scope instead of a blank page. Remove unregister.html and add
waitUntil() calls to unregister.https.html.

Bug: 452910, 688116
Change-Id: I41c42ae090837eceaf90d3b3c7c4f6383c4ef821
Reviewed-on: https://chromium-review.googlesource.com/753202
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513927}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants