Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @font-face rules to load TrueType and OpenType test fonts. #8494

Merged
merged 3 commits into from May 22, 2018

Conversation

fred-wang
Copy link
Contributor

@fred-wang fred-wang commented Nov 29, 2017

This commit removes the support/FontsToInstall directory and moves the
TrueType and OpenType test fonts directly into the support/ directory.
It attaches a support/test-fonts.css stylesheet to test pages so that
these test fonts are loaded via @font-face rules. Finally, the
instructions to install test fonts, the CSS rule for the installation
note as well as the "flags" meta tags are removed.

See discussions in issue #8440 ; note that these changes have essentially be done automatically using sed but be sure to check the following files:

 css/WOFF2/available-001.xht                          |   2 --
 .../{FontsToInstall => }/SFNT-CFF-Fallback.otf       | Bin
 .../{FontsToInstall => }/SFNT-CFF-Reference.otf      | Bin
 .../{FontsToInstall => }/SFNT-TTF-Fallback.ttf       | Bin
 .../{FontsToInstall => }/SFNT-TTF-Reference.ttf      | Bin
 css/WOFF2/support/available-001a.xht                 |   2 +-
 css/WOFF2/support/available-001b.xht                 |   2 +-
 css/WOFF2/support/index.css                          |  11 -----------
 css/WOFF2/support/test-fonts.css                     |  19 +++++++++++++++++++
 css/WOFF2/testcaseindex.xht                          |   1 -

See also issue #8482 for the available test.

This commit removes the support/FontsToInstall directory and moves the
TrueType and OpenType test fonts directly into the support/ directory.
It attaches a support/test-fonts.css stylesheet to test pages so that
these test fonts are loaded via @font-face rules. Finally, the
instructions to install test fonts, the CSS rule for the installation
note as well as the "flags" meta tags are removed.
@fred-wang
Copy link
Contributor Author

cc'ing @litherum @gsnedders @jfkthame

@w3c-bots
Copy link

w3c-bots commented Nov 29, 2017

Build PASSED

Started: 2017-11-29 12:50:58
Finished: 2017-11-29 13:14:36

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

@gsnedders
Copy link
Member

Bah, none of these actually have <link rel=match href=foo-ref.xht>, I'll fix that in a new commit in a second.

@gsnedders
Copy link
Member

OK, after those extra changes this LGTM.

@fred-wang
Copy link
Contributor Author

@khaledhosny, @svgeesus, @rsheeter Can one of you please review this PR?

@gsnedders
Copy link
Member

reviewers: ping!

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks correct.

@svgeesus svgeesus merged commit 31c2aeb into master May 22, 2018
@gsnedders gsnedders deleted the woff2-fonts-to-install-as-web-fonts branch May 22, 2018 13:40
@fred-wang
Copy link
Contributor Author

@gsnedders @svgeesus Thanks for your help on this!

@fred-wang fred-wang restored the woff2-fonts-to-install-as-web-fonts branch June 2, 2018 06:30
@fred-wang fred-wang deleted the woff2-fonts-to-install-as-web-fonts branch June 2, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants