New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @font-face rules to load TrueType and OpenType test fonts. #8494
Conversation
This commit removes the support/FontsToInstall directory and moves the TrueType and OpenType test fonts directly into the support/ directory. It attaches a support/test-fonts.css stylesheet to test pages so that these test fonts are loaded via @font-face rules. Finally, the instructions to install test fonts, the CSS rule for the installation note as well as the "flags" meta tags are removed.
cc'ing @litherum @gsnedders @jfkthame |
Build PASSEDStarted: 2017-11-29 12:50:58 Failing Jobs
View more information about this build on: |
Bah, none of these actually have |
OK, after those extra changes this LGTM. |
@khaledhosny, @svgeesus, @rsheeter Can one of you please review this PR? |
reviewers: ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks correct.
@gsnedders @svgeesus Thanks for your help on this! |
This commit removes the support/FontsToInstall directory and moves the
TrueType and OpenType test fonts directly into the support/ directory.
It attaches a support/test-fonts.css stylesheet to test pages so that
these test fonts are loaded via @font-face rules. Finally, the
instructions to install test fonts, the CSS rule for the installation
note as well as the "flags" meta tags are removed.
See discussions in issue #8440 ; note that these changes have essentially be done automatically using sed but be sure to check the following files:
See also issue #8482 for the available test.