New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the animation-worklet IDL file #9758
Update the animation-worklet IDL file #9758
Conversation
Build PASSEDStarted: 2018-03-07 21:40:05 View more information about this build on: |
b27ef56
to
057df5b
Compare
void registerAnimator(DOMString name, VoidFunction animatorCtor); | ||
}; | ||
|
||
[Constructor (DOMString animatorName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a spec bug here: WICG/animation-worklet#96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's been fixed in WICG/animation-worklet#98 and here now.
057df5b
to
354717f
Compare
I've added a test but it's broken because of WICG/animation-worklet#96, suggest just waiting until that's fixed. |
@flackr @majido @stephenmcgruer this adds you as owners of this directory with a single test as well. Is that OK? Maybe you want to put some tests in here? :) Tentative tests are fine: http://web-platform-tests.org/writing-tests/file-names.html |
@foolip adding us as owner sounds good. I didn't know about |
OK, WICG/animation-worklet#96 is fixed, now this just needs to be synced with the new IDL. |
@foolip - updated, but the test is broken because of a bunch of undeclared deps (which aren't in any of the imported IDL). |
Added a missing dep, and now it's broken because 'promise_test: Unhandled rejection with value: object "Partial interface AnimationEffectReadOnly with no original interface"' AnimationEffectReadOnly used to be in https://drafts.csswg.org/web-animations/ but now there's just AnimationEffect. Tried to fix it but it was too messy, filed WICG/animation-worklet#101. |
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/
directory (instead of inline copies in the test files).