Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the animation-worklet IDL file #9758

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@w3c-bots
Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-07 21:40:05
Finished: 2018-03-07 21:55:26

View more information about this build on:

@lukebjerring lukebjerring force-pushed the idl-file-updates-animation-worklet branch from b27ef56 to 057df5b Compare March 7, 2018 20:20
void registerAnimator(DOMString name, VoidFunction animatorCtor);
};

[Constructor (DOMString animatorName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a spec bug here: WICG/animation-worklet#96

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's been fixed in WICG/animation-worklet#98 and here now.

@foolip
Copy link
Member

foolip commented Apr 6, 2018

I've added a test but it's broken because of WICG/animation-worklet#96, suggest just waiting until that's fixed.

@foolip
Copy link
Member

foolip commented Apr 6, 2018

@flackr @majido @stephenmcgruer this adds you as owners of this directory with a single test as well. Is that OK?

Maybe you want to put some tests in here? :) Tentative tests are fine: http://web-platform-tests.org/writing-tests/file-names.html

@majido
Copy link
Member

majido commented Apr 6, 2018

@foolip adding us as owner sounds good.

I didn't know about tentative. We have a bunch of test for AnimationWorklet and ScrollTimeline that should be possible to upstream.

@foolip
Copy link
Member

foolip commented Apr 8, 2018

OK, WICG/animation-worklet#96 is fixed, now this just needs to be synced with the new IDL.

@lukebjerring
Copy link
Contributor Author

@foolip - updated, but the test is broken because of a bunch of undeclared deps (which aren't in any of the imported IDL).

@domenic domenic removed their request for review April 20, 2018 21:21
@foolip
Copy link
Member

foolip commented Jun 8, 2018

Added a missing dep, and now it's broken because 'promise_test: Unhandled rejection with value: object "Partial interface AnimationEffectReadOnly with no original interface"'

AnimationEffectReadOnly used to be in https://drafts.csswg.org/web-animations/ but now there's just AnimationEffect. Tried to fix it but it was too messy, filed WICG/animation-worklet#101.

@lukebjerring lukebjerring added this to In progress in Improve idlharness.js Jun 18, 2018
@lukebjerring lukebjerring moved this from In progress to To do in Improve idlharness.js Jun 18, 2018
@lukebjerring lukebjerring moved this from To do to In progress in Improve idlharness.js Jun 18, 2018
@lukebjerring lukebjerring merged commit c483fe4 into web-platform-tests:master Jul 19, 2018
Improve idlharness.js automation moved this from In progress to Done Jul 19, 2018
@lukebjerring lukebjerring deleted the idl-file-updates-animation-worklet branch October 5, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants