Reland "ServiceWorker: Add WPT to check if CSP sandbox is respected" #9803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ace9aca718c50119897f3d20e1d3ed81e6c0cced. The test actually crashes only when DCHECK is on. The difference from the original patch is adding -expected.txt file and changing [ Crash ] to [ Crash Pass ]. TBR=falken@chromium.org Bug: 771815 Change-Id: I9354c80c6e1478160214151065f6f0cbf25ad862 Reviewed-on: https://chromium-review.googlesource.com/948242 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540783}
wpt-pr-bot
approved these changes
Mar 5, 2018
Build PASSEDStarted: 2018-03-05 05:46:33 Failing Jobs
View more information about this build on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ace9aca718c50119897f3d20e1d3ed81e6c0cced.
The test actually crashes only when DCHECK is on.
The difference from the original patch is adding -expected.txt file and changing
[ Crash ] to [ Crash Pass ].
TBR=falken@chromium.org
Bug: 771815
Change-Id: I9354c80c6e1478160214151065f6f0cbf25ad862
Reviewed-on: https://chromium-review.googlesource.com/948242
Reviewed-by: Makoto Shimazu shimazu@chromium.org
Commit-Queue: Makoto Shimazu shimazu@chromium.org
Cr-Commit-Position: refs/heads/master@{#540783}