Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the requestidlecallback IDL file #9825

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@w3c-bots
Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 05:03:56
Finished: 2018-03-08 05:11:59

View more information about this build on:

@lukebjerring lukebjerring force-pushed the idl-file-updates-requestidlecallback branch from 5132789 to bf93c12 Compare March 7, 2018 20:31
@lukebjerring lukebjerring added this to In progress in Improve idlharness.js Jun 18, 2018
@lukebjerring lukebjerring moved this from In progress to To do in Improve idlharness.js Jun 18, 2018
@lukebjerring lukebjerring moved this from To do to In progress in Improve idlharness.js Jun 27, 2018
Copy link
Contributor

@rmcilroy rmcilroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@foolip foolip merged commit b1681c1 into web-platform-tests:master Jul 16, 2018
Improve idlharness.js automation moved this from In progress to Done Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants