Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent silent access flag proposed changes #216

Open
npm1 opened this issue Apr 24, 2023 · 2 comments
Open

Prevent silent access flag proposed changes #216

npm1 opened this issue Apr 24, 2023 · 2 comments

Comments

@npm1
Copy link
Contributor

npm1 commented Apr 24, 2023

The spec currently sets the flag when preventSilentAccess() is called on the origin that invoked the method.

We want to take advantage of this in FedCM, but to do so we have a proposed change: make the flag per domain, instead of per origin. This is because that is how usually logins work. In fact, it appears Chrome implementation of the existing usage is already per-domain...

Another issue: currently the prevent silent access flag only works for credentials from Collect, not for credentials from Discover. This is an issue because FedCM does all of its work in Discover. We therefore need to reimplement the logic for mediation inside our Discover method, but there is a step that would technically be incorrect: "If options’ mediation is "silent", resolve p with null, and skip the remaining steps." For FedCM, this should not happen.

@npm1
Copy link
Contributor Author

npm1 commented Apr 24, 2023

Never mind, I missed the requires user mediation. Does this mean that if an iframe invokes the API and the top-level calls preventSilentAccess() then the iframe can still invoke the API later without issue? That seems like an issue.

@npm1 npm1 changed the title Prevent silent access flag is not used in algorithms Prevent silent access flag proposed changes Apr 26, 2023
@npm1
Copy link
Contributor Author

npm1 commented Apr 26, 2023

Repurposing this issue to propose some modification to preventSilentAccess. cc @yi-gu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant