Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashes bypass source-based allowlisting only on pre-request, not on post-request #523

Open
antosart opened this issue Nov 8, 2021 · 2 comments

Comments

@antosart
Copy link
Member

antosart commented Nov 8, 2021

On script/style pre-request checks, if the integrity hashes match then we skip source-based matching check. This means that script-src 'self' 'sha512-abc' passes the pre-request check for a cross-origin script with matching hash.

However, that would be blocked on post-request, since we have no logic for hashes there anymore.

As with nonces, I believe we would like to allow the request in this case.

@antosart
Copy link
Member Author

antosart commented Nov 8, 2021

CC @koto

@koto
Copy link
Member

koto commented Nov 8, 2021

Thanks for filing, Antonio. For context, linking also to #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants