Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WebDriver Extension Capability #1353

Merged
merged 3 commits into from Jan 22, 2020

Conversation

nsatragno
Copy link
Member

@nsatragno nsatragno commented Dec 6, 2019

Add a WebDriver capability that indicates support for the Virtual Authenticators automation API. This simplifies integration between browser automation frameworks and the automation API.

Fixes #1351


Preview | Diff

Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this looks good, modulo a few minor questions/comments -- thx @nsatragno !

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @nsatragno !

Copy link
Contributor

@jcjones jcjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, and simplifies WebDriver.

@jcjones jcjones merged commit 6349d24 into w3c:master Jan 22, 2020
WebAuthnBot pushed a commit that referenced this pull request Jan 22, 2020
WebAuthnBot pushed a commit that referenced this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a capability to the WebAuthn WebDriver extension
4 participants