Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup Credential Source by Credential ID Algorithm returns sensitive data such as the credential private key #1678

Open
equalsJeffH opened this issue Oct 28, 2021 · 0 comments
Assignees
Labels
@Risk Items that are at risk for L3 type:editorial
Milestone

Comments

@equalsJeffH
Copy link
Contributor

the Lookup Credential Source by Credential ID Algorithm is presently used only in internal-to-the-authenticator operations, namely in authenticatorMakeCredential and authenticatorGetAssertion.

The result of Lookup Credential Source by Credential ID Algorithm is null, or one or more credential sources. A credential source models the (sensitive) data an authnr manages for each "credential", i.e., including the credential private key.

Using this alg to look up a cred source, when conceptually "within the authenticator boundary" is fine (i.e., security- and privacy-wise).

However, if we attempt to use this alg from another conceptual level, e.g., the client platform (as we might do in PR #1576), then we do not want to be returning the private key to the caller.

authenticatorMakeCredential and authenticatorGetAssertion really only need this alg to return cred source items such as type, (cred) id, rpId, userHandle, otherUI (i.e., everything other than privateKey).

We ought to update this alg accordingly such that security model subtleties remain at least nominally correct.

@equalsJeffH equalsJeffH added this to the L3-WD-01 milestone Oct 28, 2021
@nadalin nadalin added the @Risk Items that are at risk for L3 label Jun 27, 2023
@plehegar plehegar modified the milestones: L3-WD-01, L3-WD-02 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@Risk Items that are at risk for L3 type:editorial
Projects
None yet
Development

No branches or pull requests

4 participants