Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the [SameObject] attribute from PublicKeyCredential::authenticatorAttachment #1977

Closed
jschanck opened this issue Sep 27, 2023 · 1 comment · Fixed by #1981
Closed

Remove the [SameObject] attribute from PublicKeyCredential::authenticatorAttachment #1977

jschanck opened this issue Sep 27, 2023 · 1 comment · Fixed by #1981
Labels
stat:pr-open subtype:algorithms/WebIDL type:technical

Comments

@jschanck
Copy link

The WebIDL standard says

The [SameObject] extended attribute must not be used on anything other than a read only attribute whose type is an interface type or object.

The authenticatorAttachment field of PublicKeyCredential is a nullable DOMString which is neither an interface type nor an object.

Proposed Change

Remove [SameObject] from

webauthn/index.bs

Line 1524 in baf774a

[SameObject] readonly attribute DOMString? authenticatorAttachment;

@emlun emlun mentioned this issue Oct 2, 2023
Merged
@emlun
Copy link
Member

emlun commented Oct 2, 2023

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat:pr-open subtype:algorithms/WebIDL type:technical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove [SameObject] attribute from PublicKeyCredential.authenticatorAttachment w3c/webauthn
2 participants
@emlun @jschanck