Explicitly specify binary encoding for string truncation #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
suggested changes
Jan 19, 2024
emlun
force-pushed
the
issue-1994-binary-trunc-encoding
branch
from
a7c2ded
to
527629c
Compare
aphillips
reviewed
Jan 22, 2024
agl
reviewed
Jan 24, 2024
agl
reviewed
Jan 24, 2024
emlun
force-pushed
the
issue-1994-binary-trunc-encoding
branch
from
9b7e211
to
8f89a8e
Compare
aphillips
reviewed
Feb 28, 2024
plehegar
added
the
i18n-tracker
aphillips
reviewed
Mar 14, 2024
|
From the call of 2024-05-15: ok to land after agl reviews. |
agl
approved these changes
May 15, 2024
agl
reviewed
May 15, 2024
| @@ -3194,7 +3194,9 @@ associated with or [=scoped=] to, respectively. | |||
|
|
|||
| When [=clients=], [=client platforms=], or [=authenticators=] display a {{PublicKeyCredentialEntity/name}}'s value, they should always use UI elements to provide a clear boundary around the displayed value, and not allow overflow into other elements [[css-overflow-3]]. | |||
|
|
|||
| Authenticators MAY truncate a {{PublicKeyCredentialEntity/name}} member's value so that it fits within 64 bytes, if the authenticator stores the value. See [[#sctn-strings-truncation]] about truncation and other considerations. | |||
| When storing a {{PublicKeyCredentialEntity/name}} member's value, | |||
There was a problem hiding this comment.
Very minor nit: this comma (and in the next diff hunk) read oddly to me, but I'm happy either way.
There was a problem hiding this comment.
Hm, I see. If you don't mind I'll keep it as is, if only for consistency with the first sentence in the paragraph immediately preceding this (and also the next hunk).
github-actions bot
added a commit
that referenced
this pull request
May 27, 2024
SHA: fabbc09 Reason: push, by emlun Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1994.
Preview | Diff