Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move AAGUID for selecting authnr into new AuthenticatorSelectionCriteria #442

Closed
wants to merge 6 commits into from

Conversation

rlin1
Copy link
Contributor

@rlin1 rlin1 commented May 4, 2017

Close #441


Preview | Diff

@rlin1
Copy link
Contributor Author

rlin1 commented May 5, 2017

Close #446
Close #447


<pre class="idl">
enum KeyProtection {
"SW", // key protected by Rich-OS software
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment is not enough to specify what these fields do.

@jyasskin
Copy link
Member

jyasskin commented May 5, 2017

More generally, if you actually want these fields added in a timely manner, you should send them in separate PRs so that a field that gets consensus isn't held up behind more contentious or harder-to-specify fields. Showing a unified framework for these fields in an issue could help build support for them, but even then it's wise to add them separately.

@equalsJeffH
Copy link
Contributor

@jyasskin noted on call just now something about this interacting with pr #460

@equalsJeffH
Copy link
Contributor

@jyasskin notes on the call just now: this PR has 3 components: AAGUID, key protection, matcher protection. all should be evaluated independently (separate PRs). matcher protection could be moved into PR #460 but not necessarily.

@selfissued
Copy link
Contributor

I agree with @jyasskin that each independent piece of functionality should be placed into its own PR so that it can be evaluated independently. This was agreed to on the 24-May-17 WG call.

@rlin1
Copy link
Contributor Author

rlin1 commented May 29, 2017

Will close (unmerged) this PR and create individual PRs for adding aaguidList, keyProtection and matcherProtection to Authenticator SelectionCriteria.

@rlin1 rlin1 closed this May 29, 2017
@emlun emlun deleted the authnr-sel-addtl-fields branch June 22, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants