New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move AAGUID for selecting authnr into new AuthenticatorSelectionCriteria #442
Conversation
|
||
<pre class="idl"> | ||
enum KeyProtection { | ||
"SW", // key protected by Rich-OS software |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment is not enough to specify what these fields do.
More generally, if you actually want these fields added in a timely manner, you should send them in separate PRs so that a field that gets consensus isn't held up behind more contentious or harder-to-specify fields. Showing a unified framework for these fields in an issue could help build support for them, but even then it's wise to add them separately. |
I agree with @jyasskin that each independent piece of functionality should be placed into its own PR so that it can be evaluated independently. This was agreed to on the 24-May-17 WG call. |
Will close (unmerged) this PR and create individual PRs for adding aaguidList, keyProtection and matcherProtection to Authenticator SelectionCriteria. |
Close #441
Preview | Diff