-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where are rsaAlgName and eccAlgName defined? #568
Comments
This is artifact left over previous to COSE Key change. This is supposed to be alg: COSEAlgorithmIdentifier. |
PR #580 replaces the uses of rsaAlgName and eccAlgName with COSEAlgorithmIdentifier. I'd like feedback on whether we should also replace uses of the strings "ED256" and "ED512", which refer to the algorithms defined at https://fidoalliance.org/specs/fido-uaf-v1.1-id-20170202/fido-ecdaa-algorithm-v1.1-id-20170202.html#ecdaa-algorithm-names, with new COSEAlgorithmIdentifier values. If so, I would add these to the IANA registrations at http://www.w3.org/TR/2017/WD-webauthn-20170811/#sctn-cose-alg-reg. |
Yes, we should also replace "ED256" and "ED512" with COSE identifier. |
I have not seen any COSE identifiers for those yet. |
These have been added to PR #580 . Please review. |
The
packed
andtpm
attestation statement formats reference the typesrsaAlgName
andeccAlgName
, saying "The typesrsaAlgName
andeccAlgName
are as defined in §5.3.1 Attestation data". Section §5.3.1 however doesn't reference these terms, and neither does the RFC8152 cited therein to define the COSE_Key format.Where are
rsaAlgName
andeccAlgName
defined? Are they supposed to be the parameteralg: COSEAlgorithmIdentifier
defined in §5.3.1 Attestation data?The text was updated successfully, but these errors were encountered: